Printable View
uploading shortly a new update for Site Map XML to version 4 for ZC1.5.7 if accepted, should show up on it's own. If you are interested in helping out, got some ideas or just want something to play with, GitHub location.
I still have some things I want to play with, but for now as is it's working as before on ZC1.5.7 and PHP7.4 with allot easier install. A number of files was changed or deleted, thus I would not suggest this as a easy update, but a new install.
Thanks for the effort, duly noted.
If you use the EzPage template, it was pointed out that the language wasn't following along. Actually, it had some issues with tables and such so I cleaned it up and push to GitHub. I have no way to test it, so if you do, please let me know it it's working as you would expect it to.. Thanks..
Thanks for the work on this plugin. I noticed a few things. First, \includes\templates\template_default\sitemapxml\html_header.php has a missing closing curly bracket. Second, the first parameter passed to the $snifer->field_exists and $sniffer->table_exists in \includes\modules\pages\sitemapxml\sitemapxml_ezpages.php should be without quotes. And third, TABLE_EZPAGES_TEXT is used but TABLE_EZPAGES_CONTENT should be used instead in \includes\modules\pages\sitemapxml\sitemapxml_ezpages.php. With these modifications I was able to generate the three xml files for categories, products and ezpages. Haven't tried the others.
Looks like header page got cut short... ezpage is in Github not the download yet as pointed out in the post.. still working on some things to add..Quote:
Originally Posted by vasilt
well push up the corrected header file too..
pushed to Github fixes for bugs pointed out as well code changes.
- bug.. Undefined table sent to be sniffed out. plugins that may or may not exist for all users.
- Change in ezpage, no need to sniff out what exists in ZC1.5.7!
Still working on some ideas before sending in an update.
Dave,
I was just experimenting with your plug-in (as pulled from github). It wouldn't install through Zen Cart until I changed:
$this->executeInstallerSql($sql);
to
$db->Execute($sql);
in ScriptedInstaller.php.
After that, it seemed to work.
One nitpick ... the "Create Sitemap's" button text should be "Create Sitemaps" in \admin\includes\languages\english\sitemapxml.php.
$this->executeInstallerSql($sql);Quote:
Originally Posted by jadebox
should work on ZC1.5.7 as is... I use $db->Execute($sql); for debugging but not having any issues with a vanilla install with the default $this->executeInstallerSql($sql); statement.. What's the environment?
Difference in spell check... but such is why language files are created for..
Dave, it's not a difference in spell check. The difference is between possessive (its) and contractions (it's = it is). In this case, it's the difference between plural (Sitemaps) and contractions (Sitemap's = Sitemap is).Quote:
Originally Posted by davewest
LOL.. After 70 some years you think I could figure it out... nop... 3's and E's still can't tell the difference.. I'm told quite often NOP is spelled wrong too...Quote:
Originally Posted by lat9
pushed an update for the spelling...