Views: 613,213
New Zenner
Just remove the quotes of TABLE_EZPAGES_TEXT on line 25 of \includes\modules\pages\sitemapxml\sitemapxml_ezpages.php - ```
if ($sitemapXML->dbTableExist('TABLE_EZPAGES_TEXT')) {
change to
if ($sitemapXML->dbTableExist(TABLE_EZPAGES_TEXT)) {
Totally Zenned
vasilt:
Just remove the quotes of TABLE_EZPAGES_TEXT on line 25 of \includes\modules\pages\sitemapxml\sitemapxml_ezpages.php - ```
if ($sitemapXML->dbTableExist('TABLE_EZPAGES_TEXT')) {
>
> change to
> ```
if ($sitemapXML->dbTableExist(TABLE_EZPAGES_TEXT)) {
It's a bit more complicated.. TABLE_EZPAGES_TEXT is not defined anywhere and still would fail. If you are using PHP lower then 7.3, you would not get a warning for the undefined.. replacing it with 'TABLE_EZPAGES_CONTENT' would get you closer to the fix, but there are also errors in the sql. I pushed the updated template for v4 up to Github but don't have a multilingual site to test it on. It does create the expected links. What version of ZC and PHP was the error on?
New Zenner
I use ZC 1.5.7 and PHP 7.4. And I found the definition of TABLE_EZPAGES_TEXT in \includes\extra_datafiles\ezpages_multilanguage_database_names.php which is the same as TABLE_EZPAGES_CONTENT. Removing the quotes actually did solve the problem because now the ezpages xml file includes links for all languages and throws no errors in the log files. The code is probably outdated but still this quick-fix will get us going until a new version comes out. Can you provide link to the new version in Github?
Sensei
vasilt:
I use ZC 1.5.7 ... I found the definition of TABLE_EZPAGES_TEXT in \includes\extra_datafiles\ezpages_multilanguage_database_names.php
That file should have been deleted when you upgraded to Zen Cart v1.5.6 where multi-lingual ez-pages was built-in, thus making that old plugin pointless and actually incompatible. You should go delete all the other leftovers of that plugin that aren't part of original Zen Cart code.
Totally Zenned
vasilt:
Can you provide link to the new version in Github?
https://www.zen-cart.com/downloads.php?do=file&id=2290
Zen Follower
I just installed the github release and im getting the following error on 1.57b can anyone help me work out whats wrong please???
[04-Dec-2020 23:04:19 UTC] PHP Parse error: syntax error, unexpected end of file in /includes/templates/template_default/sitemapxml/html_header.php on line 40
[04-Dec-2020 23:04:19 UTC] Request URI: /index.php?main_page=sitemapxml&rebuild=yes, IP address: 92.236.55.221
--> PHP Parse error: syntax error, unexpected end of file in /includes/templates/template_default/sitemapxml/html_header.php on line 40.
a few google searches give me various answers but im having no joy here adding symbols ect.
heres the offending code file thats throwing the error
<?php
/**
* Common Template
*
* outputs the html header. i,e, everything that comes before the \</head\> tag <br />
*
* @copyright Copyright 2003-2020 Zen Cart Development Team
* @copyright Portions Copyright 2003 osCommerce
* @license http://www.zen-cart.com/license/2_0.txt GNU Public License V2.0
* @version $Id: Zen4All 2020 May 12 Modified in v1.5.7 $
*/
/* Mobile_Detect.php old school, responsive design doesn't need scripting */
// Prevent clickjacking risks by setting X-Frame-Options:SAMEORIGIN
header('X-Frame-Options:SAMEORIGIN');
?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" <?php echo HTML_PARAMS; ?>>
<head>
<title><?php echo HEADING_TITLE; ?></title>
<meta http-equiv="Content-Type" content="text/html; charset=<?php echo CHARSET; ?>" />
<?php if (defined('FAVICON')) { ?>
<link rel="icon" href="<?php echo FAVICON; ?>" type="image/x-icon" />
<link rel="shortcut icon" href="<?php echo FAVICON; ?>" type="image/x-icon" />
<?php } //endif FAVICON ?>
<base href="<?php echo (($request_type == 'SSL') ? HTTPS_SERVER . DIR_WS_HTTPS_CATALOG : HTTP_SERVER . DIR_WS_CATALOG ); ?>" />
<style>
body {
font-family: Verdana, Geneva, sans-serif;
font-size: small;
}
</style>
</head>
<?php
// BOF hreflang for multilingual sites
if (!isset($lng) || (isset($lng) && !is_object($lng))) {
$lng = new language;
//> </form> </body> </html> }
zennedOut
its complaining about a missing curly bracket. at the end of your code:
// BOF hreflang for multilingual sites
if (!isset($lng) || (isset($lng) && !is_object($lng))) {
$lng = new language;
}
//> </form> </body> </html> }
no guarantees that it does what it is supposed to do though...
best.
Zen Follower
it took me a long time to spot the difference there lol thanks bud ill enter it now and report my findings back even if its a success :)
Zen Follower
I no longer get a http 500 error and have sitemap.xml's that aren't blank. thankyou :)
i had just got errors resolved from bad setup with help of a hired hand, passes it back to me i installed google merchant feeder no problem then this and by time i asked for help had 11 log files lol. :blush:
New Zenner
Why can't I find "Sitemap XML" in Admin-> Configuration->?
zenzart:1.5.7
Modified admin and template folder name
New Zenner
zswll2:
Why can't I find "Sitemap XML" in Admin-> Configuration->?
zenzart:1.5.7
Modified admin and template folder name
I reinstalled to solve this problem, but why did I get a 500 error when I clicked "save"?
Totally Zenned
zswll2:
I reinstalled to solve this problem, but why did I get a 500 error when I clicked "save"?
Two things to help others help resolve the problems experienced, 1) identify other plugins that are installed and 2) identify issues logged in the logs folder at/around the time of experiencing the issue. Remember when posting that your admin directory will appear in myDEBUG-adm files...
New Zenner
It works good for 1.5.7b. thank you
Totally Zenned
I have installed this on 1.5.7b but when I try to create the sitemap.xml files from the admin the pop up window remains blank. I hav chmod the sitemap folder to 777 and the sitemap.xml file to 777
Totally Zenned
Nick1973:
I have installed this on 1.5.7b but when I try to create the sitemap.xml files from the admin the pop up window remains blank. I hav chmod the sitemap folder to 777 and the sitemap.xml file to 777
Looked in the logs and found this PHP Parse error: syntax error, unexpected end of file in /home/DOMAINNAME/public_html/includes/templates/template_default/sitemapxml/html_header.php on line 40.
zennedOut
Nick1973:
Looked in the logs and found this PHP Parse error: syntax error, unexpected end of file in /home/DOMAINNAME/public_html/includes/templates/template_default/sitemapxml/html_header.php on line 40.
line 40 is not the EOF in the github repo...
are you sure you have the correct file? and latest version?
Totally Zenned
Nick1973:
Looked in the logs and found this PHP Parse error: syntax error, unexpected end of file in /home/DOMAINNAME/public_html/includes/templates/template_default/sitemapxml/html_header.php on line 40.
Version 4 had a messed up zip.. zip's are not the normal compression for Linux and some how the files got messed up.. Sent in a new zip which was approved... This post was for version 2, version 4 is here.. GitHub is good for ZC1.5.7x and php7.x only which is why it's not a continuation here...
Totally Zenned
davewest:
Version 4 had a messed up zip.. zip's are not the normal compression for Linux and some how the files got messed up.. Sent in a new zip which was approved... This post was for version 2, version 4 is here.. GitHub is good for ZC1.5.7x and php7.x only which is why it's not a continuation here...
It's ok I have applied the fix that you gave me and that seemed to work fine. I will look out for the new one in the future in Modules.
Zen Follower
G'day,
Google Search is giving me a warning "Indexed, not submitted in sitemap" for 800+ additional images like https://www.scubadoctor.com.au/diveshop/index.php?main_page=popup_image_additional&pID=4025&products_image_large_additional=images%2Fcressi-sub%2Fcressi-drake-freediving-spearfishing-computer_02.jpg
Since Google seems to want to insist on indexing these images, has consideration been given to including them in the sitemap output?
Best regards, Lloyd Borrett.
Administrator
lloyd_borrett:
G'day,
Google Search is giving me a warning "Indexed, not submitted in sitemap" for 800+ additional images like https://www.scubadoctor.com.au/diveshop/index.php?main_page=popup_image_additional&pID=4025&products_image_large_additional=images%2Fcressi-sub%2Fcressi-drake-freediving-spearfishing-computer_02.jpg
Since Google seems to want to insist on indexing these images, has consideration been given to including them in the sitemap output?
Best regards, Lloyd Borrett.
Lloyd, are you sure that Google's not complaining about the fact that the popup_image_additional page itself?
That page is normally present in the ROBOTS_PAGES_TO_SKIP constant, present in /includes/languages/english/meta_tags.php (or a template- or extra-language-file override)?
Fields marked required must be completed.
Tell staff why this post should be reviewed.