SitemapXML v.2

wsworx:

Can anyone tell me if this plugin will work in 1.5.7c?

Thank You
I have used this version sitemapXML3_9_6 https://www.zen-cart.com/downloads.php?do=file&id=367

ianhg:

I have used this version sitemapXML3_9_6 https://www.zen-cart.com/downloads.php?do=file&id=367

I haven't installed it yet but thank you for the follow up.

Using sitemapXML 3.9.6. And also getting the Call to undefined function zen_admin_demo() in zcadmin/sitemapxml.php line 35 error log that the other user was getting in this post

https://www.zen-cart.com/showthread.php?126810-SitemapXML-v-2&p=1384774#post1384774

Would love to lean the fix. Any time i try to save any settings in sitemapxml it gives me a blank page from admin and generates another error log.

toyseller:

woops. Have found the answer ... as there is another post

Could you post how you fixed it here ? Thanks friend :)

jasonshanks:

Could you post how you fixed it here ? Thanks friend :)

Comment lines 35 to 39 of sitemapxml.php, like this:

    /*case (zen_admin_demo()):
      $action = '';
      $messageStack->add_session(ERROR_ADMIN_DEMO, 'caution');
      zen_redirect(zen_href_link(FILENAME_SITEMAPXML));
      break;*/

Can someone possibly tell me why I would see the following error at the end of the build process in the window that pops up:

Ping Bing
http://www.bing.com/webmaster/ping.aspx?siteMap=https%3A%2F%2Fwildsteedworx.com%2Fsitemapindex.xml
cURL Error: "" reading "http://www.bing.com/webmaster/ping.aspx?siteMap=https%3A%2F%2Fwildsteedworx.com%2Fsitemapindex.xml"

wsworx:

Can someone possibly tell me why I would see the following error at the end of the build process in the window that pops up:

Ping Bing
http://www.bing.com/webmaster/ping.aspx?siteMap=https%3A%2F%2Fwildsteedworx.com%2Fsitemapindex.xml
cURL Error: "" reading "http://www.bing.com/webmaster/ping.aspx?siteMap=https%3A%2F%2Fwildsteedworx.com%2Fsitemapindex.xml"
Possibly because it's pinging** http://** instead of https://?

The Microsoft Bing search engine has quietly stopped accepting XML Sitemap pings. https://blogs.bing.com/webmaster/may-2022/Spring-cleaning-Removed-Bing-anonymous-sitemap-submission

vasilt:

The Microsoft Bing search engine has quietly stopped accepting XML Sitemap pings. https://blogs.bing.com/webmaster/may-2022/Spring-cleaning-Removed-Bing-anonymous-sitemap-submission

Thanks for that, @vasilt!

Is there any estimated time of update for this module for use with ZC 1.5.8 php 8.1? The reason for the question is below, I have 3 sites currently at 1.5.7c that I am preparing to update.

Currently I have a clean install Ubuntu 20.04 server with a virgin demo cart with data install with no modifications besides the sitemapXML module in question. I have confirmed the server meets the requirements (including PHP modules) posted in the docs for Zen Cart.

I have installed the latest sitemapxml version (3.9.6 also called V 2) on the zen cart site. Permissions have been set correctly on sitemap.xml and the sitemap root folder.

Clicking Tools SiteMap give the normal sitemap page with the various options

When I check Rebuild all .xml files (with everything else at the default selections) then click send I get a blank screen on the Pop up screen and the system logs the following warning:

[15-Nov-2022 14:42:36 America/Chicago] PHP Fatal error: Uncaught Error: Cannot access private property queryFactory::$count_queries in /var/www/alt1.humphreystowbars.com/public_html/includes/classes/sitemapxml.php:78
Stack trace:
#0 /var/www/alt1.humphreystowbars.com/public_html/includes/modules/pages/sitemapxml/header_php.php(66): zen_SiteMapXML->__construct()
#1 /var/www/alt1.humphreystowbars.com/public_html/index.php(35): require('...')
#2 {main}
thrown in /var/www/alt1.humphreystowbars.com/public_html/includes/classes/sitemapxml.php on line 78

[15-Nov-2022 14:42:36 America/Chicago] Request URI: /index.php?main_page=sitemapxml&rebuild=yes, IP address: 98.190.184.37
--> PHP Fatal error: Uncaught Error: Cannot access private property queryFactory::$count_queries in /var/www/alt1.humphreystowbars.com/public_html/includes/classes/sitemapxml.php:78
Stack trace:
#0 /var/www/alt1.humphreystowbars.com/public_html/includes/modules/pages/sitemapxml/header_php.php(66): zen_SiteMapXML->__construct()
#1 /var/www/alt1.humphreystowbars.com/public_html/index.php(35): require('...')
#2 {main}
thrown in /var/www/alt1.humphreystowbars.com/public_html/includes/classes/sitemapxml.php on line 78.

There are various forks on Github...confusing for anyone wishing to submit their fixes from a working ZC158 site.
So, who wishes to host/manage this from now?

Change $db->count_queries
To
$db->queryCount()

Although for backwards compatibility, would want to check if the method exists, if it does use the new, if it does not, use the code as it was.

E.g. the equal sign and what follows to be replaced by:

 = (method_exists($db, 'queryCount') ? $db->queryCount() : $db->count_queries);

torvista:

There are various forks on Github...confusing for anyone wishing to submit their fixes from a working ZC158 site.
So, who wishes to host/manage this from now?Yes, there are several floating around. I believe the code at https://github.com/dbltoe/Sitemap-XML-4 is the most recent but I have yet to test on 1.5.8. It does just fine on 1.5.7d but, there again, it does use the plugins folder method.

Maybe later this evening.

mc12345678:

Change $db->count_queries
To
$db->queryCount()

Although for backwards compatibility, would want to check if the method exists, if it does use the new, if it does not, use the code as it was.

E.g. the equal sign and what follows to be replaced by:

= (method_exists($db, 'queryCount') ? $db->queryCount() : $db->count_queries);

Will run into a similar issue with $db->total_query_time

With the above equivalent replacement:

= (method_exists($db, 'queryTime') ? $db->queryTime() : $db->total_query_time);

I've generated a commit to address both of these issues at: <https://github.com/mc12345678/zen-cart-sitemap-xml/commit/5a0abd0ddb42c636d6408a5780f72dc96261d6af>

Though, it looks like this method has existed throughout all of 1.5.x so, really could just replace with the method instead of trying to directly access what is now a private member.

That has been updated with this commit to use the existing data class methods instead of trying to access what are now private members:
<https://github.com/mc12345678/zen-cart-sitemap-xml/commit/75597e6c10dac4492c125abcec0e66fc91d045f0>

I didn't research if those methods existed in pre 1.5.x systems. The first of these two commits would likely support that possibility.

mc12345678:

Will run into a similar issue with $db->total_query_time

With the above equivalent replacement:

= (method_exists($db, 'queryTime') ? $db->queryTime() : $db->total_query_time);

> 
> I've generated a commit to address both of these issues at: <https://github.com/mc12345678/zen-cart-sitemap-xml/commit/5a0abd0ddb42c636d6408a5780f72dc96261d6af>
> 
> Though, it looks like this method has existed throughout all of 1.5.x so, really could just replace with the method instead of trying to directly access what is now a private member.
> 
> That has been updated with this commit to use the existing data class methods instead of trying to access what are now private members:
> <https://github.com/mc12345678/zen-cart-sitemap-xml/commit/75597e6c10dac4492c125abcec0e66fc91d045f0>
> 
> I didn't research if those methods existed in pre 1.5.x systems. The first of these two commits would likely support that possibility.
Brilliant that seems to have worked for me Zencart 1.5.8 Bootstrap V3.5.0 and PHP7.4.. Thanks you

@mc
I downloaded the** zen-cart-sitemap.xml 158 **zip from your repository from GitHub and when unzipped the files I get a error Access Denied.

I install Zencart 1.57d using third party product "Inveo_Magic_SEO_URLs_for_ZenCart_6.2.00" for better URL format on PHP 7.3
Do we have a version of sitemapXML compatible with 1.57d and third party product?

This one should be working.

You can also try https://github.com/dbltoe/Sitemap-XML-4 BUT, all bets are off with the "off-brand" SEO. :(

haredo:

@mc
I downloaded the** zen-cart-sitemap.xml 158 **zip from your repository from GitHub and when unzipped the files I get a error Access Denied.

The "Access Denied" message is a little vague. Almost so much so, I don't know of a "simple" question to ask. I've never simply unzipped a file on my local computer to get that message, I've never had a server simply unzip a file to get that message. I have gotten a similar message if I had limited access rights to a Zen Cart site and I tried to access an area to which I thought I had access but didn't.

So I'm a little confused about how simply unzipping the file would necessarily cause an access denied response, unless there is or was more to the story.

Is this a Windows-protecting-you thing...right click on it and see if there is some option to unblock it?