SitemapXML v.2

ttfan:

It seems that some of my disabled products are included in the sitemap. Is this normal?

When did the XML files get generated as compared to the product going disabled? If you generate the files again, do the inactive product drop off?

Hey guys! I am upgrading to 1.5.5.f and just installed the mod. Seems to be working, except the Configuration Menu is not formatting correctly.

Here is a screenshot:

[Attachment no longer available]

Any idea what is wrong? We had existing configuration from our previous install, so do we need to uninstall the Sitemap Configuration table, and then do a fresh install?

Jeff_Mash:

Hey guys! I am upgrading to 1.5.5.f and just installed the mod. Seems to be working, except the Configuration Menu is not formatting correctly.

Here is a screenshot:

Any idea what is wrong? We had existing configuration from our previous install, so do we need to uninstall the Sitemap Configuration table, and then do a fresh install?
Seems that the line:
Active plugins sitemapxml_categories.php;sitemapxml_mainpage.php;sitemapxml_manufacturers.php;sitemapxml_products.php;sitemapxml_products_reviews.php;sitemapxml_testimonials.php
Is too long... it's not editable and I don't know if the code has a trim to apply to it, but if the list were generated with a space between each module, perhaps it would wrap around and allow the edit box to either be on the right or down at the bottom.

As far as anything wrong with the module itself, no that is not the cause of this responsive screen response. The configuration menu is made of a set of code to apply to all configurations and just renders what is in the database.

mc12345678:

Seems that the line:
Active plugins sitemapxml_categories.php;sitemapxml_mainpage.php;sitemapxml_manufacturers.php;sitemapxml_products.php;sitemapxml_products_reviews.php;sitemapxml_testimonials.php
Is too long... it's not editable and I don't know if the code has a trim to apply to it, but if the list were generated with a space between each module, perhaps it would wrap around and allow the edit box to either be on the right or down at the bottom.

As far as anything wrong with the module itself, no that is not the cause of this responsive screen response. The configuration menu is made of a set of code to apply to all configurations and just renders what is in the database.

Yeah, I just was doing a little experiment and the problem is definitely due to that "Active Plugins" line. When I remove the value from the database, the Admin Menu looks normal.

I have no idea why it's even a configuration variable if it's not editable. Here is a screenshot to illustrate that point:

[Attachment no longer available]

Jeff_Mash:

Yeah, I just was doing a little experiment and the problem is definitely due to that "Active Plugins" line. When I remove the value from the database, the Admin Menu looks normal.

I have no idea why it's even a configuration variable if it's not editable. Here is a screenshot to illustrate that point:

[Attachment no longer available]
Well, the "edit" is by the selection of modules in the program itself. Those options get stored in the database and the effect of storing it as a contiguous string was not something of an issue before. Otherwise the menu is still functional just looks weird.

mc12345678:

Well, the "edit" is by the selection of modules in the program itself. Those options get stored in the database and the effect of storing it as a contiguous string was not something of an issue before. Otherwise the menu is still functional just looks weird.

I just thought it was strange to give an "update" button, when you can't really update anything in that variable configuration.

Overall, it's not a huge deal since the module still works. I just wonder, "Is your menu all wonky like mine with that long string?" Or do you not have a long string in your Active Plugins value?

I'm getting the following error logged when installing on zc 1.5.5f, running on PHP 5.6.30

PHP Warning: Illegal string offset 'SITEMAPXML_DIR_WS' in /Applications/MAMP/htdocs/tier1test/stOry-NTp-cOast/includes/modules/sitemapxml_install.php on line 34

Any ideas what is causing this?

strelitzia:

I'm getting the following error logged when installing on zc 1.5.5f, running on PHP 5.6.30

PHP Warning: Illegal string offset 'SITEMAPXML_DIR_WS' in /Applications/MAMP/htdocs/tier1test/stOry-NTp-cOast/includes/modules/sitemapxml_install.php on line 34

Any ideas what is causing this?
Are lines 19 or 22 of the same file commented out?

mc12345678:

Are lines 19 or 22 of the same file commented out?

No. It's a completely stock file. I've only just downloaded it from the plugins section.

And fyi, previous version of sitemap exists.

The next thought would be that $default may not be properly identified to be an array.

Would suggest that starting at line 17 to insert the following and leave a line between the bottom of this and the top of the next if statement:

if (!isset($default) || !is_array($default)) $default = array();

mc12345678:

The next thought would be that $default may not be properly identified to be an array.

Would suggest that starting at line 17 to insert the following and leave a line between the bottom of this and the top of the next if statement:

if (!isset($default) || !is_array($default)) $default = array();

That solved the problem. I uploaded the module with your edit to a fresh install and no error was generated. The module appears to have installed correctly as all the expected menu items are there under configuration, and the page under Tools is present.

Thanks for the help.

Just following up mc12345678 about adding spaces to stop the menu going all over. That worked for me.

I edited sitemapxml_install.php on roughly line 56 like this:

'SITEMAPXML_PLUGINS' => array(CFGTITLE_SITEMAPXML_PLUGINS, 'sitemapxml_categories.php; sitemapxml_mainpage.php; sitemapxml_manufacturers.php; sitemapxml_products.php; sitemapxml_products_reviews.php; sitemapxml_testimonials.php', CFGDESC_SITEMAPXML_PLUGINS, 15, null, 'zen_cfg_read_only('),

And the menu formatted correctly.

I have another problem though. When you go to Tools > Sitemap XML all I get is a button saying 'Upgrade SitemapXML SQL'. When I click it, it upgrades Sitemap XML even though it was a fresh install. But after upgrading, the button remains. I've tried commenting the button out of admin/sitemapxml.php but that doesn't work and leaves a blank screen. Any ideas?

This is what is happening

The installer is looking a little buggy:

admin/includes/modules/sitemapxml_install.php - line 24 - 27:

if (defined('SITEMAPXML_CHECK_DUBLICATES')) {
$sql = "UPDATE " . TABLE_CONFIGURATION . " SET configuration_key='SITEMAPXML_CHECK_DUPLICATES' where configuration_key='SITEMAPXML_CHECK_DUBLICATES'";
$db->Execute($sql);
}

wants to be:
if (defined('SITEMAPXML_CHECK_DUPLICATES')) {
$sql = "UPDATE " . TABLE_CONFIGURATION . " SET configuration_key='SITEMAPXML_CHECK_DUPLICATES' where configuration_key='SITEMAPXML_CHECK_DUPLICATES'";
$db->Execute($sql);
}

twitchtoo:

The installer is looking a little buggy:

admin/includes/modules/sitemapxml_install.php - line 24 - 27:

if (defined('SITEMAPXML_CHECK_DUBLICATES')) {
$sql = "UPDATE " . TABLE_CONFIGURATION . " SET configuration_key='SITEMAPXML_CHECK_DUPLICATES' where configuration_key='SITEMAPXML_CHECK_DUBLICATES'";
$db->Execute($sql);
}

wants to be:
if (defined('SITEMAPXML_CHECK_DUPLICATES')) {
$sql = "UPDATE " . TABLE_CONFIGURATION . " SET configuration_key='SITEMAPXML_CHECK_DUPLICATES' where configuration_key='SITEMAPXML_CHECK_DUPLICATES'";
$db->Execute($sql);
}

That doesn't make sense. The first set of code says: if the configuration_key is misspelt, correct the spelling. The second says: if it is spelt correctly just make it the same with no change.

Historically the plugin had an incorrect spelling for that key. In more recent versions, the spelling was changed. The installer recognizes and corrects the historical mistake.

Just updating you guys on my issue. I had my website running locally on my machine using MAMP. When I put it live the Sitemap module worked correctly. So it was an issue when installing on a website if running a site through MAMP.

I just used the stock files after recreating a website that had it installed before. What I saw before did not look like the normal sitemap mod so I figured it was a version created by someone else. Now I have the same issue reported before with the uneditable and weird looking settings. I do think it best to uninstall this first as the database was the only thing pulled from the site for this new site. So first I installed it on a test site with 1.5.5.f. Same results so there is something wrong with this.

delia:

I just used the stock files after recreating a website that had it installed before. What I saw before did not look like the normal sitemap mod so I figured it was a version created by someone else. Now I have the same issue reported before with the uneditable and weird looking settings. I do think it best to uninstall this first as the database was the only thing pulled from the site for this new site. So first I installed it on a test site with 1.5.5.f. Same results so there is something wrong with this.
Suggest at least two things. As usual addressing the items of the posting tips, little assistance can be directly offered when not knowing the conditions involved (results in a post similar to this in most cases). Second reviewing at least the recent posts. There have been a few things identified as a result of the way some things were coded as compared to the direction more up-to-date php has gone.

Sorry. The problem is what Jeff_Mash reported. Css is obviously wonky and no variables are editable which I see is the way it was in previous versions. I had never noticed that before.

Nick1973:

I have another problem though. When you go to Tools > Sitemap XML all I get is a button saying 'Upgrade SitemapXML SQL'. When I click it, it upgrades Sitemap XML even though it was a fresh install. But after upgrading, the button remains. I've tried commenting the button out of admin/sitemapxml.php but that doesn't work and leaves a blank screen. Any ideas?

I had the same problem. I checked, and double checked that all the files had been uploaded correctly.

I resolved it by doing the following:

admin/includes/modules/sitemapxml_install.php

Uncommented line 14 and changed the version number to 3.9.5
$current_version = '3.9.5';

Pressing the "Upgrade SitemapXML SQL" button again resulted in the options page now displaying correctly.