SitemapXML v.2

torvista:

Regarding url rewriters...

Native url: https://www.site.com/index.php?main_page=product_info&cPath=1_5_1847&products_id=2309
Friendly url: https://www.site.com/widgets/widget1

I would have thought the best option would be to always submit the native url (doesn't change) instead of the friendly url, to avoid links becoming obsolete with minor name changes, which I do often.

What does the panel think?

This is another piece of "SEO is complicated."

The URL rewriter should be redirecting visitors to the SEO-friendly URL, among other reasons because you don't want to submit the same content at multiple different URLs (that can have a negative impact on that particular page as well as on the entire site). But you do not want to have the search engines hitting a URL the server immediately tells them is wrong by redirecting them. And you do want the search engines seeing the friendly URLs - that's why you made them search engine friendly in the first place. And you want to tell the search engines what URL to go to (and that should be the one you want them to index). And you don't want to be changing the URLs of pages a lot.

So, the URL in the sitemap should be the friendly, rewritten URL for a number of SEO reasons, but at the same time, while you want to make your URLs as good for SEO as you can (if you're using a friendly URL generator), you really don't wan to be changing them too often.

torvista:

Regarding url rewriters...

Native url: https://www.site.com/index.php?main_page=product_info&cPath=1_5_1847&products_id=2309
Friendly url: https://www.site.com/widgets/widget1

I would have thought the best option would be to always submit the native url (doesn't change) instead of the friendly url, to avoid links becoming obsolete with minor name changes, which I do often.

What does the panel think?

I also agree the rewritten url (if that is the approach chosen by the store owner) should be used. I have a client that had problems getting indexed. We believe part of the problem was the sitemap submitted was the default url. Google crawls the url getting a 301 to the rewritten url. The canonical was the default. It creates this loop that Google cannot ever index the url it's given via the sitemap or canonical.

While I believe this is the correct answer, it is also why choosing to use rewritten url's is no easy decision. You lock yourself into a url structure. Should the plugin be abandoned, you could be forced to all new urls...unless the new one (say CEON) allows you to set the new ones to match the old, but this is not always possible.

Thanks for the information.

I have a problem, only when using a cron job to rebuild the categories sitemap.

It's php 7.1.26.

This is the debug log:
[07-Mar-2019 22:47:02 Europe/Madrid] PHP Fatal error: Allowed memory size of 33554432 bytes exhausted (tried to allocate 16384 bytes) in /home/XXXXXXXX/public_html/tienda/includes/classes/db/mysql/query_factory.php on line 45
[07-Mar-2019 22:47:02 Europe/Madrid] PHP Fatal error: Allowed memory size of 33554432 bytes exhausted (tried to allocate 16384 bytes) in /home/XXXXXXXX/public_html/tienda/includes/extra_configures/enable_error_logging.php on line 31
[07-Mar-2019 22:47:02 Europe/Madrid] PHP Warning: Unknown: Cannot call session save handler in a recursive manner in Unknown on line 0
[07-Mar-2019 22:47:02 Europe/Madrid] PHP Warning: Unknown: Failed to write session data using user defined save handler. (session.save_path: /home/XXXXXXXX/public_html/tienda/cache) in Unknown on line 0

It builds a file with 1201 entries then dies, every time.

If I reduce the SITEMAP_MAX_ENTRIES in the class to 500, then it creates three files, two complete of 500 and one broken of 28 entries.

Note that my table rows are:
categories: 2,187
categories description: 4,374 (dual language site)
products to categories: 103,235 (not a typo)

Executing the cgi-bin file from the browser works ok, it is only the cron that fails.

...further to this, the cron job can be set to use different versions of php.
When using 5.4/5.5/5.6 it works.
When using 7.0/7.1 it fails.

Hi everyone, I noticed that in the product sitemap it puts the url to an image that doesn't exist ... I use Image Handler 5

see image here
https://i.postimg.cc/kGf6BFW0/Cattura.jpg

can anyone help with this error?
thank you

First of all... Thank you guys for a great module......

Zen Cart 1.5.6a
Database Patch Level: 1.5.6
PHP Version: 7.2.17 (Zend: 3.2.0)
<<<modules>>>
backup_mysql
encrypted_master_password
keep_cart
numinix-google-analytics
remember me
usu-3.0
Image Handler 5
SiteMapXML

I had just added SitemapXML to my site and these are the errors I have gotten. 3 Errors total

[24-Apr-2019 21:47:43 America/Chicago] Request URI: /ADMIN/index.php, IP address: XX.XX.XX,XX
#1 require_once(/home/shrimps/public_html/ADMIN/includes/languages/english/sitemapxml.php) called at [/home/shrimps/public_html/ADMIN/includes/modules/sitemapxml_install.php:15]
#2 require_once(/home/shrimps/public_html/ADMIN/includes/modules/sitemapxml_install.php) called at [/home/shrimps/public_html/ADMIN/includes/init_includes/init_sitemapxml.php:95]
#3 require(/home/shrimps/public_html/ADMIN/includes/init_includes/init_sitemapxml.php) called at [/home/shrimps/public_html/includes/autoload_func.php:48]
#4 require(/home/shrimps/public_html/includes/autoload_func.php) called at [/home/shrimps/public_html/ADMIN/includes/application_top.php:171]
#5 require(/home/shrimps/public_html/ADMIN/includes/application_top.php) called at [/home/shrimps/public_html/ADMIN/index.php:10]
--> PHP Warning: Use of undefined constant SITEMAPXML_SITEMAPINDEX - assumed 'SITEMAPXML_SITEMAPINDEX' (this will throw an Error in a future version of PHP) in /home/shrimps/public_html/ADMIN/includes/languages/english/sitemapxml.php on line 14.

[24-Apr-2019 21:47:43 America/Chicago] Request URI: /ADMIN/index.php, IP address: XX.XX.XX,XX
#1 require_once(/home/shrimps/public_html/ADMIN/includes/languages/english/sitemapxml.php) called at [/home/shrimps/public_html/ADMIN/includes/modules/sitemapxml_install.php:15]
#2 require_once(/home/shrimps/public_html/ADMIN/includes/modules/sitemapxml_install.php) called at [/home/shrimps/public_html/ADMIN/includes/init_includes/init_sitemapxml.php:95]
#3 require(/home/shrimps/public_html/ADMIN/includes/init_includes/init_sitemapxml.php) called at [/home/shrimps/public_html/includes/autoload_func.php:48]
#4 require(/home/shrimps/public_html/includes/autoload_func.php) called at [/home/shrimps/public_html/ADMIN/includes/application_top.php:171]
#5 require(/home/shrimps/public_html/ADMIN/includes/application_top.php) called at [/home/shrimps/public_html/ADMIN/index.php:10]
--> PHP Warning: Use of undefined constant SITEMAPXML_SITEMAPINDEX - assumed 'SITEMAPXML_SITEMAPINDEX' (this will throw an Error in a future version of PHP) in /home/shrimps/public_html/ADMIN/includes/languages/english/sitemapxml.php on line 36.

[24-Apr-2019 21:47:43 America/Chicago] Request URI: /ADMIN/index.php, IP address: XX.XX.XX,XX
#1 require_once(/home/shrimps/public_html/ADMIN/includes/modules/sitemapxml_install.php) called at [/home/shrimps/public_html/ADMIN/includes/init_includes/init_sitemapxml.php:95]
#2 require(/home/shrimps/public_html/ADMIN/includes/init_includes/init_sitemapxml.php) called at [/home/shrimps/public_html/includes/autoload_func.php:48]
#3 require(/home/shrimps/public_html/includes/autoload_func.php) called at [/home/shrimps/public_html/ADMIN/includes/application_top.php:171]
#4 require(/home/shrimps/public_html/ADMIN/includes/application_top.php) called at [/home/shrimps/public_html/ADMIN/index.php:10]
--> PHP Warning: Use of undefined constant TABLE_SITEMAPXML_EXTRAURLS - assumed 'TABLE_SITEMAPXML_EXTRAURLS' (this will throw an Error in a future version of PHP) in /home/shrimps/public_html/ADMIN/includes/modules/sitemapxml_install.php on line 135.

[24-Apr-2019 21:57:48 America/Chicago] Request URI: /index.php?main_page=sitemapxml&ping=yes, IP address: XX.XX.XX,XX
#1 mysqli_free_result() called at [/home/shrimps/public_html/includes/modules/pages/sitemapxml/sitemapxml_products.php:122]
#2 include(/home/shrimps/public_html/includes/modules/pages/sitemapxml/sitemapxml_products.php) called at [/home/shrimps/public_html/includes/templates/template_default/sitemapxml/tpl_main_page.php:21]
#3 require(/home/shrimps/public_html/includes/templates/template_default/sitemapxml/tpl_main_page.php) called at [/home/shrimps/public_html/index.php:97]
--> PHP Warning: mysqli_free_result() expects parameter 1 to be mysqli_result, null given in /home/shrimps/public_html/includes/modules/pages/sitemapxml/sitemapxml_products.php on line 122.

[24-Apr-2019 21:57:49 America/Chicago] Request URI: /ADMIN/sitemapxml.php, IP address: XX.XX.XX,XX
#1 require_once(/home/shrimps/public_html/ADMIN/includes/modules/sitemapxml_install.php) called at [/home/shrimps/public_html/ADMIN/sitemapxml.php:21]
--> PHP Warning: Use of undefined constant TABLE_SITEMAPXML_EXTRAURLS - assumed 'TABLE_SITEMAPXML_EXTRAURLS' (this will throw an Error in a future version of PHP) in /home/shrimps/public_html/ADMIN/includes/modules/sitemapxml_install.php on line 135.

Linux
PHP 7.0.33
My SQL 5.6.43
Fresh install 1.5.6b

Hi,
Does this work on 1.5.6b?
This was the easiest thing to get to work back in the old days. Now I spent last 2 hours on it and I can't seem to get it to work.
I remember with old versions there were blank example XML sitemaps (categories, products, reviews, etc.) to put in store folder (under /public_html)
This is not mentioned in V.2 instructions. I just didn't want to assume that this version would generate those blank XML files and write to them so I put them there like we used to. So I go to the admin panel, work through configuration and try to write to those xml files through admin/tools. AND I get nothing but frozen screen. Please see attached screen shots. All permissions are set 777 including the sitemap folder.

Any help is highly appreciated.

... and if it helps following is what I get in error logs:

[13-Jun-2019 16:09:29 UTC] PHP Fatal error: Uncaught Error: Call to a member function isMobile() on null in /home/mgs10000/public_html/includes/templates/responsive_classic/common/main_template_vars.php:32
Stack trace:
#0 /home/mgs10000/public_html/index.php(49): require()
#1 {main}
thrown in /home/mgs10000/public_html/includes/templates/responsive_classic/common/main_template_vars.php on line 32

[13-Jun-2019 16:09:29 UTC] Request URI: /index.php?main_page=sitemapxml&rebuild=yes&ping=yes, IP address: 73.107.135.155
--> PHP Fatal error: Uncaught Error: Call to a member function isMobile() on null in /home/mgs10000/public_html/includes/templates/responsive_classic/common/main_template_vars.php:32
Stack trace:
#0 /home/mgs10000/public_html/index.php(49): require()
#1 {main}
thrown in /home/mgs10000/public_html/includes/templates/responsive_classic/common/main_template_vars.php on line 32.

The /includes/templates/responsive_classic/common/main_template_vars.php makes use of an instance of the Mobile_Detect class which hasn't been declared at that point. So you can try to add the following lines of code right before line 32 of main_template_vars.php:

if (!isset($detect)) {
	if (!class_exists('Mobile_Detect')) {
      include_once(DIR_WS_CLASSES . 'Mobile_Detect.php');
    }  
    $detect = new Mobile_Detect;
  }

Just submitted an update to this plugin v3.9.6 incorporating changes recently discussed here as well as the changes noted on @torvista's fork. Can be obtained from https://github.com/mc12345678/zen-cart-sitemap-xml or once approved from the download area: https://www.zen-cart.com/downloads.php?do=file&id=367

@mc
I would hope you are going to create a new master for this on your Github?

torvista:

@mc
I would hope you are going to create a new master for this on your Github?
Well no thanks to microsoft edge, but in my previous post was a link to my github which is extended from the late Andrew Berezin. The repo I have does include it's own master including having captured changes I saw you had posted in your fork of the software. I did not start a new one. Yes it does have an effect on the easibility of use/search within github, but I guess having had it already and it's origin I didn't want to just "drop" the linkage. Seemed a little too soon at least from my perspective.

The repo discussed above is: https://github.com/mc12345678/zen-cart-sitemap-xml

mc12345678:

Just submitted an update to this plugin v3.9.6 incorporating changes recently discussed here as well as the changes noted on @torvista's fork. Can be obtained from https://github.com/mc12345678/zen-cart-sitemap-xml or once approved from the download area: https://www.zen-cart.com/downloads.php?do=file&id=367
If hadn't seen, the above version has been posted for download at: https://www.zen-cart.com/downloads.php?do=file&id=367&uid=6845

One thing to note for users of the Russian language portion is that some modification may still be necessary for the language file to prevent issues generated when working with higher php 7.x versions and/or strict php operation. See the English version of the language file for layout/format and translation. A pull request with such an update is welcome.

Hi mc12345678,
I'm trying to install this module, thanks for the upload, and have a question about a filename, which under linux appears like a strange choice, not sure if it is intentional, and cannot find any instructions in the package (so I assume all files to be copied to server).

sitemapXML/YOUR_Admin/-install-sitemapxml.php

This filename begins with a hyphen. Confused....

Ah cr*p, silly me, looking at the contents of the file shows it should be deleted from the server. Sorry for the noise!!

gernot:

Hi mc12345678,
I'm trying to install this module, thanks for the upload, and have a question about a filename, which under linux appears like a strange choice, not sure if it is intentional, and cannot find any instructions in the package (so I assume all files to be copied to server).

sitemapXML/YOUR_Admin/-install-sitemapxml.php

> This filename begins with a hyphen. Confused....
> 
> Ah cr*p, silly me, looking at the contents of the file shows it should be deleted from the server. Sorry for the noise!!
No problem. Just revisited it as well to see the same. The right thing to do would be to add that file into some sort of to delete section of the instructions or at least an explanation about it. Big thing is/was that if it were "dutifully" uploaded that it's contents were effectively empty. Sure non-existent would be better, but at least there is no conflicting code, no if someone else executed it it will do something bad... also unfortunately this is one of those things where it is unfortunate that a software package lasts so long... the filename "mistake(s)" of the past forever haunt... 

Hope you're having an otherwise wonderful day!

Thanks for the heads up!
I'm checking the installation now. In admin, under Tools -> Sitemap XML,
there are instructions on what to do once the sitemaps have been generated.
The "more" link in step 3

Specify the Sitemap location in your robots.txt file (more...):goes to
http://sitemaps.org/protocol.php#submit_robots
but this page entirely is not available.

Correctly, it should be
https://www.sitemaps.org/protocol.html#submit_robots

Note I did not check yet if the reference to this site appears elsewhere.

Another thing: internet ageing...
The module version information (and also the footer when in Tools -> Sitemap XML), reports
http://www.ecommerce-service.com/
But again, this site does not exist anymore. Not sure whether that was at one time a sponsor for the development, a portal for support, or something? But if it is not live anymore, perhaps putting that in documentation as a legacy reference would be acceptable?
And replacing the link in the module information (Configuration -> Sitemap XML) with a link to the support thread?
And the footer in (Tools -> Sitemap XML) maybe just leave as the default Zen Cart footer in the sitemap template.

Just suggestions for future updates. Only on the admin side so no effect on customers, I am happy to ignore.

After some more searching I see that site was apparently that of the previous, sadly departed, developer. Unfortunately, I don't see any continuation of that sitename.

Hi all,,

Having some trouble using SitemapXML . It only seems to generate links for 5000 products and now to has a HTTP 500 Internal Server Error when trying to generate a new sitemap.xml. I have seen other Zencart sites that are using SitemapXML but have over 5000 products , how do I activate this feature ?

Thanks
Hash