One-Page Checkout [Support Thread]

I'll note that this is a 'base' Zen Cart issue, not specific to OPC. I've opened the issue on the Zen Cart GitHub repository: https://github.com/zencart/zencart/issues/6023

lat9:

I'll note that this is a 'base' Zen Cart issue, not specific to OPC. I've opened the issue on the Zen Cart GitHub repository: https://github.com/zencart/zencart/issues/6023

@lat9

Thank you!

jpda

jpda:

Hello Cindy,

I should have sent you this *before *my previous post on october, 25th.

I had changed shipping.php, but the only available shipping method storepickup was not selected as cheapest.
IMHO because storepickup has an option to register more than one pickup point with different prices.

Did some testing described in my post https://www.zen-cart.com/showthread.php?220781-One-Page-Checkout-Support-Thread&p=1397504#post1397504

Thanks,

@jpda
Please note that DrByte has provided a correction on the Zen Cart GitHub (https://github.com/zencart/zencart/pull/6027/commits/c7b78bb13cfdbdf770f71cb652b01164048b9c77).

@jpda, could you confirm that those changes correct the issue that you identified?

lat9:

Please note that DrByte has provided a correction on the Zen Cart GitHub (https://github.com/zencart/zencart/pull/6027/commits/c7b78bb13cfdbdf770f71cb652b01164048b9c77).

@jpda, could you confirm that those changes correct the issue that you identified?

@lat9
Short answer: no, they didn't.

Explanation:
I am testing on:
zc157d
OPC 2.4.6 (OPC is essential))
shipping method: storepickup with 5 locations, each with their own price.
Problem was: shipping methods are shown but none selected -> payment choices are not shown.

To test the github version of shipping.php, I only replaced its public function cheapest() in the v157d shipping.php.
(The entire github version of shipping.php doesn't work in my v157d environment.)

Tested, but no joy.
Did some debugging:
Changed line 272:

 } elseif ($size === 1) {

in:

} elseif (count($modules_with_quotes) === 1) {

Reason:
module storepickup with more than one location has a $size that equals the number of locations (5 in my example).
Now it works. :smile:
Even whith more shipping modules than only storepickup, it is still working.
Tried with flat rate and table and storepickup together.
The lowest price is selected by OPC, even if it is one of the storepickup locations. Payment choices are shown.

Tested without OPC enabled. Three or four page checkout, no cheapest selected, user needs to select shipping to continue to next screen.

Would this be a solution?

Thanks,

jpda

@jpda, would you post your "Pickup Locations" setting for the storepickup module (or send to me via PM) so that I can (a) replicate the issue and (b) give your solution a try?

lat9:

@jpda, would you post your "Pickup Locations" setting for the storepickup module (or send to me via PM) so that I can (a) replicate the issue and (b) give your solution a try?
@lat9
Of course, copy this string in storepickup:
Loc_A, 9.50;Loc_B, 2.50;Loc_C, 4.50;Loc_D, 7.50;Loc_E, 0.50
and whatever you want for taxes.
I have set CHECKOUT_ONE_ENABLE_SHIPPING_BILLING = true.

Thanks,

@jpda

@lat9
Forgot this:
Shipping Cost
0.00

Tax Basis
Shipping

Thanks for the info, @jpda. I'll look at that over the weekend.

lat9:

Thanks for the info, @jpda. I'll look at that over the weekend.

The change in shipping.php that I posted was:

 } elseif (count($modules_with_quotes) === 1) {

is not correct if storepickup is not the only method available because count($modules_with_quotes) > 1.

I changed that line to: (rather weird...)

   } elseif (true) {

and then it works also when other shipping methods are available.
The selected price is not always the cheapest.:(
If I find a better solution, I will let you know.

@jpda

jpda:

...

I changed that line to: (rather weird...)

} elseif (true) {

> ...

code is never weird....  it is code...  understanding it can be difficult.

without getting into the logic in question here, the above line of code would be better suited as:

} else {

best.

carlwhat:

code is never weird.... it is code... understanding it can be difficult.

without getting into the logic in question here, the above line of code would be better suited as:

} else {

> 
> best.

I understand the code, "weird" referred to my putting "true" at that place! :smile:
Quick changes, just testing. :laugh:
Thanks anyway!

jpda:

The change in shipping.php that I posted was:

} elseif (count($modules_with_quotes) === 1) {

> is not correct if storepickup is not the only method available because count($modules_with_quotes) > 1.
> 
> I changed that line to: (rather weird...)
> ```
   } elseif (true) {

and then it works also when other shipping methods are available.
The selected price is not always the cheapest.:(
If I find a better solution, I will let you know.

@jpda

I did fInd a better solution. :smile:
I'll send the public function "cheapest" via pm.

Thanks,

@jpda

Hi Cindy! It's been a LONG time!

I'm building a test site to upgrade to 1.5.8a, and have minimal changes so far - ZCA Bootstrap, and added OPC 2.4.6.

It looks great so far, and a bunch faster too.

OPC works great for a logged-in user (me), but FAILS for a guest checkout:
Sorry, we are not accepting payments from your region at this time.
Please contact us for alternate arrangements.

Two payment modules :
COD - Ontario zone
moneyorder - NO ZONE

Both are available and work properly if logged in, but not guest

https://www.beadfx.com/shop
Play as you'd like

Thanks!
Dan
BeadFX

Make sure OPC Order Total is set to

#ottotal > .ot-text

for bootstrap

Your Guest Checkout Methods?

DTomlinson:

Hi Cindy! It's been a LONG time!

I'm building a test site to upgrade to 1.5.8a, and have minimal changes so far - ZCA Bootstrap, and added OPC 2.4.6.

It looks great so far, and a bunch faster too.

OPC works great for a logged-in user (me), but FAILS for a guest checkout:
Sorry, we are not accepting payments from your region at this time.
Please contact us for alternate arrangements.

Two payment modules :
COD - Ontario zone
moneyorder - NO ZONE

Both are available and work properly if logged in, but not guest

www.beadfx.com/shop
Play as you'd like

Thanks!
Dan
BeadFX
One of the OPC configuration settings identifies payment methods are disallowed to guests (Guest Checkout: Disallowed Payment Methods). That setting's default is (drum roll) 'moneyorder, cod'.

Just update that setting to be a blank and you'll be good-to-go.

lat9:

One of the OPC configuration settings identifies payment methods are disallowed to guests (Guest Checkout: Disallowed Payment Methods). That setting's default is (drum roll) 'moneyorder, cod'.

Just update that setting to be a blank and you'll be good-to-go.

Oh my! How did I miss that one.

Sleepy time!

DTomlinson:

Oh my! How did I miss that one.

Sleepy time!
There are a ton of settings! Glad you found it.

I installed OPC on v1.5.8 test site yesterday. On checkout the following headers are not shown properly. I can't seem to figure out how to insert the defines for these items.
MODULE_ORDER_TOTAL_COUPON_TITLE
MODULE_ORDER_TOTAL_GV_TITLE
Next to the input box the header there is missing these defines
MODULE_ORDER_TOTAL_COUPON_TEXT_ENTER_CODE
MODULE_ORDER_TOTAL_GV_TEXT_ENTER_CODE
MODULE_ORDER_TOTAL_GV_USER_PROMPT

I searched these in the forum but they didn't return any results.

southshorepizza:

I installed OPC on v1.5.8 test site yesterday. On checkout the following headers are not shown properly. I can't seem to figure out how to insert the defines for these items.
MODULE_ORDER_TOTAL_COUPON_TITLE
MODULE_ORDER_TOTAL_GV_TITLE
Next to the input box the header there is missing these defines
MODULE_ORDER_TOTAL_COUPON_TEXT_ENTER_CODE
MODULE_ORDER_TOTAL_GV_TEXT_ENTER_CODE
MODULE_ORDER_TOTAL_GV_USER_PROMPT

I searched these in the forum but they didn't return any results.
zc158 or zc158a? Those constants should be present in /includes/languages/english/modules/order_total/lang.ot_coupon.php and lang.ot_gv.php, respectively.

Sorry it is 1.5.8a
Thank you I will update there.
Those were the 2 that I added the ~ at the end of the files per the instructions. I guess I need break. Details are slipping by me. The instructions clearly do not say to rename files in 1.5.8a. :frusty:
Thank you!!