Zen Cart Logo

SitemapXML v.2

Views: 613,148

Results 1,661 to 1,680 of 2,226
28 Jun 2016, 16:44
#1661
izar74 avatar

izar74

Zen Follower

Join Date:
Mar 2009
Location:
Italy
Posts:
155
Plugin Contributions:
0

SitemapXML v.2

Hi all,

I've updated the plugin today and the update process went great, It show the correct version, everything seem fine except if i try to rebuilt the xml file or ping the search engine.. in that case it opern a blank windows that state "the page is not working".
In the log i found this error:

[28-Jun-2016 18:26:10 Europe/Rome] PHP Fatal error:  Cannot redeclare sitemapxmlerrorhandler() in /.../includes/modules/pages/sitemapxml/header_php.php on line 17

The error is pointing to this line:

function sitemapxmlErrorHandler($errno, $errstr, $errfile, $errline) {
  global $old_error_handler;
  if ($errno == 2048 && $errstr == 'is_a(): Deprecated. Please use the instanceof operator') return $old_error_handler;
  if ($errno == 8 && $errstr == 'Undefined offset: 1' && substr($errfile, -11) == 'seo.url.php') return $old_error_handler;
  if ($errno == 8 && (substr($errstr, 0, 9) == 'Constant ' && substr($errstr, -16) == ' already defined')) return $old_error_handler;
  if ($errno == 2048 && strpos($errstr, 'It is not safe to rely on the system\'s timezone settings.') !== false) return $old_error_handler;
  if ($errno == 2 && substr($errfile, -17) == 'template_func.php') return $old_error_handler;
  error_log('errno => ' . $errno . ',' . "\n" . 'errstr => \'' . $errstr . '\',' . "\n" . 'errfile => \'' . $errfile . '\',' . "\n" . 'errline => ' . $errline . ',' . "\n", 3, DIR_FS_CATALOG . 'sitemapxml.log');
  return $old_error_handler;
}

What i did to solve the problem:

  1. Reintalled all the file (uploaded again)
  2. Used the uninstall button and install it again
  3. searched for another sitemapxmlErrorHandler declaration but couldn't find it.

Using zencart 1.54, last version of Sitemap used was 3.2

Gonna try some other stuff but meanwhile if someone has suggestions I'll appreciate :-)

28 Jun 2016, 17:02
#1662
izar74 avatar

izar74

Zen Follower

Join Date:
Mar 2009
Location:
Italy
Posts:
155
Plugin Contributions:
0

Re: SitemapXML v.2

Sorry again...

Solved!

For some reason ugrading from older version didn't work...
I had to manually delete all the file (First i uninstall Sitemap using the button in the Sitemap page), afeter i uploaded all the file again, run manually the -install-sitemapxml.php, click the install button in the menu page and Voilà! It worked...

I strongly recommend to manually uninstall and delete the older version files and than do a fresh install to avoid problems.

L.

04 Jul 2016, 12:29
#1663
adrian_cioc_rlan avatar

adrian_cioc_rlan

New Zenner

Join Date:
May 2016
Location:
Bucharest
Posts:
48
Plugin Contributions:
0

Re: SitemapXML v.2

Hello,

I have a problem, can someone help?

I Installed the plug-in and seems to work just fine except that http://www.domain.ro/sitemap/sitemapmanufacturers.xml does not get written (XML Parsing Error: no element found Location: http://www.domain.ro/sitemap/sitemapmanufacturers.xml
Line Number 1, Column 1: ^)

The manufacturers are populated via EP4... funny thing is that when I add a manufacturer manually via Admin, Site Map XML sees it and writes it correctly to the file... it seems to have a problem with the manufacturers populated via CSV.

Site Map XML (3.6 26.04.2016 10:33:09) on V1.5.1, populated with EP4 4.0.34 - Beta 03-19-2016

Thanks

04 Jul 2016, 13:48
#1664
a_berezin avatar

a_berezin

Deceased

Join Date:
Aug 2004
Location:
Saint Petersburg, Russia
Posts:
1,782
Plugin Contributions:
5

Re: SitemapXML v.2

Hi,

Adrian Ciocîrlan:

Hello,

I have a problem, can someone help?

I Installed the plug-in and seems to work just fine except that http://www.domain.ro/sitemap/sitemapmanufacturers.xml does not get written (XML Parsing Error: no element found Location: http://www.domain.ro/sitemap/sitemapmanufacturers.xml
Line Number 1, Column 1: ^)

The manufacturers are populated via EP4... funny thing is that when I add a manufacturer manually via Admin, Site Map XML sees it and writes it correctly to the file... it seems to have a problem with the manufacturers populated via CSV.

Site Map XML (3.6 26.04.2016 10:33:09) on V1.5.1, populated with EP4 4.0.34 - Beta 03-19-2016

Thanks

I'm sorry, but I can't help - I don't use csv import.

04 Jul 2016, 15:21
#1665
adrian_cioc_rlan avatar

adrian_cioc_rlan

New Zenner

Join Date:
May 2016
Location:
Bucharest
Posts:
48
Plugin Contributions:
0

Re: SitemapXML v.2

a_berezin:

Hi,

I'm sorry, but I can't help - I don't use csv import.

10x

I have many products, around 3000 and past 100 manufacturers, i had to populate the site via EP....
I don't understand why the only file that doesn't work is the manufacturers.xml one, because categories, products, and so, all work and they are also uploaded with EP. Why don't you consider this option? I'm sure many others populate their websites through CSV.

What should I do? Should I reenter all the manufacturers manually(this way works) would they still corespond to the existing products?

10X
AC

04 Jul 2016, 16:13
#1666
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,513
Plugin Contributions:
177

Re: SitemapXML v.2

@Adrian,
If the CSV import of manufacturers breaks things but entering them manually via the admin works fine, then something is incomplete when processing your CSV data. Either the data isn't keyed properly, or there are records with invalid data, or maybe you've made alterations to require multiple tables for manufacturer data but your import doesn't take those into account.
Best to fix the CSV import issue, because there are probably additional bad side-effects to the bad import beyond just this XML feed issue.

04 Jul 2016, 16:35
#1667
mesnitu avatar

mesnitu

Totally Zenned

Join Date:
Aug 2014
Location:
Lisbon
Posts:
597
Plugin Contributions:
0

Re: SitemapXML v.2

right ....just check the my Manufacturers: 53 , and 48 in sitemap.... I've also use EP4 ...that's odd.

04 Jul 2016, 16:37
#1668
mesnitu avatar

mesnitu

Totally Zenned

Join Date:
Aug 2014
Location:
Lisbon
Posts:
597
Plugin Contributions:
0

Re: SitemapXML v.2

But could this be related if a manufactured has products or not ?

04 Jul 2016, 16:45
#1669
adrian_cioc_rlan avatar

adrian_cioc_rlan

New Zenner

Join Date:
May 2016
Location:
Bucharest
Posts:
48
Plugin Contributions:
0

Re: SitemapXML v.2

DrByte:

@Adrian,
If the CSV import of manufacturers breaks things but entering them manually via the admin works fine, then something is incomplete when processing your CSV data. Either the data isn't keyed properly, or there are records with invalid data, or maybe you've made alterations to require multiple tables for manufacturer data but your import doesn't take those into account.
Best to fix the CSV import issue, because there are probably additional bad side-effects to the bad import beyond just this XML feed issue.

10x DrByte,

How would I know if the import went wrong when all the manufacturers seem imported right?

They all apear in the Admin & Catalog , their pictures asign well, CEON uris asign right through admin update uri, manufacturer dropdown and product info page manufacturer sidebox work fine....every manufacturer's individual page works and sorts products right...

Does the csv import seem corrupted?

A

04 Jul 2016, 18:07
#1670
mesnitu avatar

mesnitu

Totally Zenned

Join Date:
Aug 2014
Location:
Lisbon
Posts:
597
Plugin Contributions:
0

Re: SitemapXML v.2

This has something to do with this query ( in modules/pages/sitemapxml/sitemapxml_manufacturers.php ).

Looking at db tables doesn't have a difference ( as I can see) between inserting with EP4 or in the admin in the date added.
I've change some dates added since with EP upload they add the same date and time, but no diference.

The first query **$table_status = $db->Execute("SHOW TABLE STATUS LIKE '" . TABLE_MANUFACTURERS . "'"); **
returns

[fields] => Array
        (
            [Name] => manufacturers
            [Engine] => MyISAM
            [Version] => 10
            [Row_format] => Dynamic
           [B] [Rows] => 59[/B]

But the next one :

$manufacturers = $db->Execute("SELECT m.manufacturers_id, GREATEST(m.date_added, IFNULL(m.last_modified, '0001-01-01 00:00:00')) AS last_date, mi.languages_id" . $select . "
                                 FROM " . TABLE_MANUFACTURERS . " m
                                 LEFT JOIN " . TABLE_MANUFACTURERS_INFO . " mi ON (mi.manufacturers_id = m.manufacturers_id)
                                 WHERE mi.languages_id IN (" . $sitemapXML->getLanguagesIDs() . ") " .
                                 (SITEMAPXML_MANUFACTURERS_ORDERBY != '' ? "ORDER BY " . SITEMAPXML_MANUFACTURERS_ORDERBY : ''));

[resource] => mysqli_result Object
(
[current_field] => 0
[field_count] => 3
[lengths] => Array
(
[0] => 2
[1] => 26
[2] => 1
)

        **[num_rows] => 50**
        [type] => 0
    )

............so , by this time you may have thought that I was posting a solution.... but no .... any idea why this happens ? :)

04 Jul 2016, 18:47
#1671
mesnitu avatar

mesnitu

Totally Zenned

Join Date:
Aug 2014
Location:
Lisbon
Posts:
597
Plugin Contributions:
0

Re: SitemapXML v.2

@Adrian Ciocîrlan do you have the same manufacturers ID in manufacturers_info ID table ?

I do not , but I' using a altered version of EP4 .... so I can't tell, got to check some more stuff .

04 Jul 2016, 20:39
#1672
mesnitu avatar

mesnitu

Totally Zenned

Join Date:
Aug 2014
Location:
Lisbon
Posts:
597
Plugin Contributions:
0

Re: SitemapXML v.2

Adrian Ciocîrlan:

10x DrByte,

How would I know if the import went wrong when all the manufacturers seem imported right?

They all apear in the Admin & Catalog , their pictures asign well, CEON uris asign right through admin update uri, manufacturer dropdown and product info page manufacturer sidebox work fine....every manufacturer's individual page works and sorts products right...

Does the csv import seem corrupted?

A

Check if this works : https://www.zen-cart.com/showthread.php?190417-EasyPopulate-4-0-Support-Thread&p=1314404#post1314404

For me it does , but if you have the same IDs in manufacturer and manufacturer_info.... well.... I don't know

05 Jul 2016, 07:21
#1673
a_berezin avatar

a_berezin

Deceased

Join Date:
Aug 2004
Location:
Saint Petersburg, Russia
Posts:
1,782
Plugin Contributions:
5

Re: SitemapXML v.2

mesnitu:

But could this be related if a manufactured has products or not ?
not, does not depend on the products.

05 Jul 2016, 07:28
#1674
a_berezin avatar

a_berezin

Deceased

Join Date:
Aug 2004
Location:
Saint Petersburg, Russia
Posts:
1,782
Plugin Contributions:
5

Re: SitemapXML v.2

Adrian Ciocîrlan:

Why don't you consider this option?
wow! What a strict examiner! You do not mistake? If it is important for you to make it work with EP4, understand the problem and offer solutions.

05 Jul 2016, 07:36
#1675
mesnitu avatar

mesnitu

Totally Zenned

Join Date:
Aug 2014
Location:
Lisbon
Posts:
597
Plugin Contributions:
0

Re: SitemapXML v.2

a_berezin:

not, does not depend on the products.

Thanks.

By the way, I was about to ask this before I saw this issue a spent some time around it, but, adding this to the google webmaster brings any advantages ? Or more or less it's the same using just the normal sitemap link ?

It says he will receive a fresh sitemapindex.xml....this means that the rebuild the sitemap ?

inline=yes - output file sitemapindex.xml. In Google Webmaster Tools you can define your "Sitemap URL":
http://your_domain/index.php?main_page=sitemapxml&inline=yes
And every time Google will get index.php?main_page=sitemapxml he will receive a fresh sitemapindex.xml.

05 Jul 2016, 07:42
#1676
a_berezin avatar

a_berezin

Deceased

Join Date:
Aug 2004
Location:
Saint Petersburg, Russia
Posts:
1,782
Plugin Contributions:
5

Re: SitemapXML v.2

mesnitu:

do you have the same manufacturers ID in manufacturers_info ID table ?
I do not
This is an error - a violation of the logical integrity of the database.

05 Jul 2016, 08:59
#1677
a_berezin avatar

a_berezin

Deceased

Join Date:
Aug 2004
Location:
Saint Petersburg, Russia
Posts:
1,782
Plugin Contributions:
5

Re: SitemapXML v.2

mesnitu:

By the way, I was about to ask this before I saw this issue a spent some time around it, but, adding this to the google webmaster brings any advantages ? Or more or less it's the same using just the normal sitemap link ?
What are the advantages sitemap XML?

  1. RTFM - https://support.google.com/webmasters/answer/156184
  2. Be loyal to the search engines - they appreciate it.
  3. Sitemap helps to index new products.
  4. Sitemap contains an actual list of all pages that should be indexed. In Google Search Console You can see how many of them are indexed, what errors occurred while indexing. It is very convenient.
    Notice.
    If in the store 10 products, there is no need to Sitemap.
    Sitemap - not a magic pill. This is just one of the tools that must be used in conjunction with the other.

mesnitu:

It says he will receive a fresh sitemapindex.xml....this means that the rebuild the sitemap ?
This means that the date of the site map is new, and there has changed content or not is unknown.

mesnitu:

inline=yes - output file sitemapindex.xml. In Google Webmaster Tools you can define your "Sitemap URL":
http://your_domain/index.php?main_page=sitemapxml&inline=yes
And every time Google will get index.php?main_page=sitemapxml he will receive a fresh sitemapindex.xml.
Yes. But I never use it. I generate Sitemap by the cron, once a day. It allows to save resources of the server. Trifle of course, but nice. :) Well, the static file is given much faster. Of course I'm talking about stores where thousands of products and not just 10.

Sitemap Less - anyone can easily get information about the products, categories, brands, and other selling pages. This facilitates content theft (grabbing). That too is solved - it is necessary to use protection against third-party mods. On checking the reverse DNS. Give saytmap only the robots, which have specified User-Agent and come up with search engine servers.

05 Jul 2016, 09:08
#1678
mesnitu avatar

mesnitu

Totally Zenned

Join Date:
Aug 2014
Location:
Lisbon
Posts:
597
Plugin Contributions:
0

Re: SitemapXML v.2

ok !
I've using this plugin for a long time , 3 years I think... but only now I actually read the readme file about the $_GET parameters, and that's why I've ask about the "inline=yes"

Yep, I think I'll continue with the "normal" link.
Thanks

05 Jul 2016, 09:23
#1679
a_berezin avatar

a_berezin

Deceased

Join Date:
Aug 2004
Location:
Saint Petersburg, Russia
Posts:
1,782
Plugin Contributions:
5

Re: SitemapXML v.2

mesnitu:

I've using this plugin for a long time , 3 years I think... but only now I actually read the readme file about the $_GET parameters, and that's why I've ask about the "inline=yes"

This option - an atavism. He appeared for a long time, according to your measurements - a long-long-long time ago, 12 years ago. And it remains only to maintain compatibility.

02 Aug 2016, 02:49
#1680
earth_friendly avatar

earth_friendly

New Zenner

Join Date:
Apr 2014
Location:
NJ
Posts:
59
Plugin Contributions:
0

Re: SitemapXML v.2

DrByte:

@Adrian,
If the CSV import of manufacturers breaks things but entering them manually via the admin works fine, then something is incomplete when processing your CSV data. Either the data isn't keyed properly, or there are records with invalid data, or maybe you've made alterations to require multiple tables for manufacturer data but your import doesn't take those into account.
Best to fix the CSV import issue, because there are probably additional bad side-effects to the bad import beyond just this XML feed issue.

I was just wrestling with a similar problem. Some of my manufacturers showed up in my sitemap, and some didn't, and I was scratching my head trying to figure out why. It seems that if I manually create a manufacturer, then an entry is created in both the manufacturers table and the manufacturers_info table. But if I don't create the manufacturer explicitly, and I use Easy Populate to create a new product with a new manufacturer, then Easy Populate will only create an entry in the manufacturers table, but not in the manufacturers_info table. Then, when I run sitemapxml to generate a new sitemap, the new manufacturer will not show up in the sitemapmanufacturers.xml file. Problem solved :smile:: I just need to create each manufacturer before using it in a new product in Easy Populate. I fixed the problem by deleting and recreating these manufacturers explicitly, and then running Easy Populate again to connect the products to the manufacturers. And now my sitemapmanufacturers.xml file contains 14 manufacturers rather than 5 manufacturers.