Image Handler 2 (for ZC v1.3.8 ONLY) Support

@DivaVocals
Sorry I missed that thread.

mzimmers:

May I ask what all the discussion about PHP 5.3 is about? Is this a new version that all the hosting services are about to move to?

Regarding reinstallation: I guess if I file compare the add-on to the core 139, I'll see a list of the files that get modified. The other files in the add-on should be bolt-in. For the files with overlap, it looks like some quality time with a three-way merge tool is in order. Ah well...it still beats working for a living.I suggest a forum or Google search as a full blown PHP 5.3 discussion is very much off topic here.. Hosting services are moving to PHP 5.3, and many apps using functions deprecated in PHP 5.3 will no longer work. IH2 has some of this in it's code and so it's an issue that needs to be addressed.

haredo:

@DivaVocals
Sorry I missed that thread.No worries.. I figured you might be interested in a PHP 5.3 compatible version.. :smile: One of the folks who will be testing the new version is reporting that he is having no PHP 5.3 compatibility issues with Rev 7 of IH2.. But I think that is just luck.. :laugh:

DivaVocals:

No worries.. I figured you might be interested in a PHP 5.3 compatible version.. :smile: One of the folks who will be testing the new version is reporting that he is having no PHP 5.3 compatibility issues with Rev 7 of IH2.. But I think that is just luck.. :laugh:

I'm also having no problems using Rev 7 of IH2 on my local test server using php5.3

@cyldejones
are you having issues with this version also:

http://www.zen-cart.com/index.php?main_page=product_contrib_info&products_id=1629

I did a directory comparison between 1.3.9 and IH2 with 1.3.8 as the ancestor. It looks like the following files within IH2 have changed either in IH2 or in 1.3.9:

includes/modules/additional_images.php
includes/modules/main_product_image.php
includes/modules/pages/popup_image/header_php.php
includes/modules/pages/popup_image_additional/header_php.php
includes/templates/template_default/popup_image_additional/tpl_main_page.php

Of these, the only file that has changes in BOTH IH2 and 1.3.9 is:

includes/modules/pages/popup_image/header_php.php

So, would I be correct in assuming that if I reapply all the 1.3.9 files to my shop, then merge the header_php.php file, then install IH2, I should be OK? I realize that I'll then have to do a similar exercise with Lightbox.

Thanks.

haredo:

@cyldejones
are you having issues with this version also:

I haven't even downloaded this since I've never had any problems with IH2 vis a vie additional images.

Here is a clear explanation of what I did - if this helps.

1. The latest version of IH2 revised by ckosloff BROKE the additional images function on the product info page. So... if someone added additional images to their products - and they also had that version of IH2 installed - the additional images DID NOT SHOW UP. EVERY site we have tried to install that updated IH2 on did the same thing and we have always had to uninstall and go back to the prior version to get this functionality.

2. So... as I stated in the description - I took the older version originally created by Tim Kroger - one version before the latest version - and changed one or two of the files that needed to be changed to work with 1.3.9

I have tons of clients that NEED those extra images to show up - and I am sure there are many out there that want to use additional images on their product pages - so that is why I renamed it a little to include that it supported the additional images.

I am NOT a coder and I definately am not trying to take "credit" for this mod - I am just trying to help people who need those additional images on their product page.

If this update is a problem with everyone - then I am happy to ask the developers of zen cart to remove it. But until such time that ckosloff (who updated the prior version) or someone else can get the additional images to work in his code and also upgrade it for 1.3.9 - I think it is a necessary addon - at least for the moment....

DivaVocals:

Have you taken a close look at the the version of IH2 Judy Gunderson has submitted. Her version doesn't MAJORLY change ANYTHING in IH2 so why she submitted it as a NEW and separate module is beyond me..

After comparing her version last night to Rev 7 of IH2 it seems clear that she should have submitted it as an UPDATE with a MUCH BETTER explanation of what she "did" in her submission notes.. Also her "version" implies that it fixes a problem that was never a problem (that I was a aware of) even with the new version of Zen Cart.

My point was I would not pay ANYONE to make this particular version (the Judy Gunderson version) of IH2 PHP 5.3 compatible since with the exception of a VERY MINOR change I do not see ANYTHING ELSE different in her version. (and since I'm not a coder, I will be asking a friend or two to help me interpret the code that Judy did add to IH2 to determine WHAT it is supposed to do)

Other than the hover on medium images (which has NEVER been coded into IH2 and which I imagine WOULD be a fairly complicated undertaking if compatibility with lightbox mods is to be maintained..) what features don't work???

I posted yesterday that I will be submitting a PHP 5.3 compatible version of the ORIGINAL IH2. The changes to make IH2 PHP 5.3 compatible are MINOR at best and do not warrant a major version number change.

I am of the opinion that updating the Judy Gunderson version with no real understanding of WHAT SHE CHANGED is not a good idea.. Which is why I PERSONALLY would not pay to fix THAT version..

Nothing.. I have paid for feature coding before, but my point was that I personally wouldn't spend ANY money on a version of IH2 which is VAGUELY documented, and as far as I can tell brings NOTHING new to the table.

She (Judy Gunderson) in essence took the Rev 7 version of IH2, add a LITTLE bit of code to it, made some VAGUE reference to some "broken" functionality (that has NEVER been broken or even reported broken), changed NONE of the supporting documentation, and then submitted it as a NEW mod (instead of an update to the existing mod) Now if YOU want to pay to have THAT version updated to make it PHP 5.3 compatible, knock yourself out..:laugh: I will submit Rev 8 (as an UPDATE to Rev 7) to the downloads section, and it won't cost me or anyone a dime to use it..:smile:

Are you saying that the most up to date version of IH2 Ver 2.0 rev 7 is working with additional images? I believe you may have the version PRIOR to that - which works for additional images.

clydejones:

I haven't even downloaded this since I've never had any problems with IH2 vis a vie additional images.

stellarweb:

Are you saying that the most up to date version of IH2 Ver 2.0 rev 7 is working with additional images? I believe you may have the version PRIOR to that - which works for additional images.

I'm using version of IH2 Ver 2.0 rev 7 and yes it is working with additional images.

mzimmers:

I did a directory comparison between 1.3.9 and IH2 with 1.3.8 as the ancestor. It looks like the following files within IH2 have changed either in IH2 or in 1.3.9:

includes/modules/additional_images.php
includes/modules/main_product_image.php
includes/modules/pages/popup_image/header_php.php
includes/modules/pages/popup_image_additional/header_php.php
includes/templates/template_default/popup_image_additional/tpl_main_page.php

Of these, the only file that has changes in BOTH IH2 and 1.3.9 is:

includes/modules/pages/popup_image/header_php.php

So, would I be correct in assuming that if I reapply all the 1.3.9 files to my shop, then merge the header_php.php file, then install IH2, I should be OK? I realize that I'll then have to do a similar exercise with Lightbox.

Thanks.
I saw where your lightbox works but still no watermark...
did you ever activate for the med image when seen by hovering small image to have the watermark.

I notice that your small image and the hover of it are the same size...maybe that is why the watermark does not want to cooperate with the large image...have you tried increasing the size of your medium image?

did you place these into an override folder in includes/modules/your template folder/additional_images.php and main_product_image.php

along with the ones from the templates section too that and editing the files (header ones in pages) helped too so if you have not edited the new ffiles with the ih2 info then that may be why it does not wish to behave totally.

that is how i have mine set up and it behaves that and editing the files in pages (header ones) helped

This is me... eating CROW BIG TIME!!

I just installed the latest version of IH2 and the additional image upload function is now working.

My apologies - When it first came out, we tested it many times and the additional images would not upload. This has obviously been fixed and I was unaware of it.

Dr. BYTE - can you delete the version I put up there??

clydejones:

I'm using version of IH2 Ver 2.0 rev 7 and yes it is working with additional images.

Here was my "beef" as it were in a nutshell.. Your version of IH2 was submitted to the downloads section as if it was a **NEW RE-WRITE **of Image Handler (which would be the ONLY reason to submit an add-on as a NEW add-on versus an UPDATE ro an existing add-on). Based on what I saw in my review there was NOTHING new, it looked like an UPDATE. (albeit an update based on incorrect data)

I get that you were trying to share and help the community, but you did this with little to NO explanation as to the changes you made when your mod was submitted (ALL of the documentation ckosloff and I wrote were included in your submission with no updates to the changelog at all). Your description of your add-on was identical to the original IH2 add-on with the only change being the VAGUEST of references to a "broken" feature.

You also NEVER stopped by this support thread to inform the community who uses Rev 7 of IH2 of your plans to update it. If you had, the members of the community who use Rev 7 surely would have told you (which is what occurred today) that the "broken feature" you were "fixing" was NEVER broken at all..

Now there are some who took exception to my pointing any of this out and thought I was giving you a hard time.. Not my intent. My concern was the confusion your version could cause. Because of how it was submitted, because the documentation was vague, and because it could cause confusion to the community. Not everyone will take the time to do an analysis to see what a NEW version REALLY brings to the table. Some community member will assume that if it's a NEW version, it must REALLY be new...

stellarweb:

Here is a clear explanation of what I did - if this helps.

1. The latest version of IH2 revised by ckosloff BROKE the additional images function on the product info page. So... if someone added additional images to their products - and they also had that version of IH2 installed - the additional images DID NOT SHOW UP. EVERY site we have tried to install that updated IH2 on did the same thing and we have always had to uninstall and go back to the prior version to get this functionality.

2. So... as I stated in the description - I took the older version originally created by Tim Kroger - one version before the latest version - and changed one or two of the files that needed to be changed to work with 1.3.9

I have tons of clients that NEED those extra images to show up - and I am sure there are many out there that want to use additional images on their product pages - so that is why I renamed it a little to include that it supported the additional images.

**I am NOT a coder and I definately am not trying to take "credit" for this mod - I am just trying to help people who need those additional images on their product page. **

If this update is a problem with everyone - then I am happy to ask the developers of zen cart to remove it. But until such time that ckosloff (who updated the prior version) or someone else can get the additional images to work in his code and also upgrade it for 1.3.9 - I think it is a necessary addon - at least for the moment....

No worries.. However, I'm not sure what files you've been working off of.. Since the Rev 7 release neither ckosloff nor I have made any additional changes to the Rev 7 files.. What's available now is the same files that ckosloff compiled and submitted as Rev 7.

stellarweb:

This is me... eating CROW BIG TIME!!

I just installed the latest version of IH2 and the additional image upload function is now working.

My apologies - When it first came out, we tested it many times and the additional images would not upload. This has obviously been fixed and I was unaware of it.

Dr. BYTE - can you delete the version I put up there??

clydejones:

I'm also having no problems using Rev 7 of IH2 on my local test server using php5.3Awesome!!! The changes required for PHP 5.3 compatibility are minor.. I don't profess to understand them all.. I simply know which lines need to be changed, and what to change them to..:laugh::laugh:

You should but remember after you install IH2, you need to compare the lightbox files with the files in your shop.. That's why EVERY SINGLE mod tells you to BACKUP your store first.. There's two reasons for this

1. you can rollback your store if a module install goes horribly wrong.
2. You can use these files to do your win merges so you are merging your changes into your existing store files. (which may have ALREADY been modified)

I normally make a two backups.. 1 to allow me an easy rollback path, and the other I call my "working files" which is where I do my merges. I upload the changed files from my working copy to my development site. If all goes well great.. If it goes to hell in a handbasket, I rollback..

mzimmers:

I did a directory comparison between 1.3.9 and IH2 with 1.3.8 as the ancestor. It looks like the following files within IH2 have changed either in IH2 or in 1.3.9:

includes/modules/additional_images.php
includes/modules/main_product_image.php
includes/modules/pages/popup_image/header_php.php
includes/modules/pages/popup_image_additional/header_php.php
includes/templates/template_default/popup_image_additional/tpl_main_page.php

Of these, the only file that has changes in BOTH IH2 and 1.3.9 is:

includes/modules/pages/popup_image/header_php.php

So, would I be correct in assuming that if I reapply all the 1.3.9 files to my shop, then merge the header_php.php file, then install IH2, I should be OK? I realize that I'll then have to do a similar exercise with Lightbox.

Thanks.

His issue is not caused by any of his IH2 settings.. His settings are fine, and his medium hover is working fine.

His lightbox and IH2 touch the same product page files. Since he did not merge these changes, his lightbox wiped out the IH2 code on his product page.

DarkAngel:

I saw where your lightbox works but still no watermark...
did you ever activate for the med image when seen by hovering small image to have the watermark.

Again - apologies for my error in updating the mod previous to the current one that in my experiences did NOT allow for upload of additional images. Crow has been eaten - and lesson learned from your posts - thanks.

To be honest, <wearing my heart on my sleeve> I have "worried" and even taken offense by your posts and because of that I will most certainly not submit updates any other mods to work with 1.3.9 other than the ones I have already submitted HOPING to help the community. I will leave it to others like you to do this and keep my 1.3.9 updated files on my computer and not share them with anyone other than my immediate clients in the future. :(

DivaVocals:

Here was my "beef" as it were in a nutshell.. Your version of IH2 was submitted to the downloads section as if it was a **NEW RE-WRITE **of Image Handler (which would be the ONLY reason to submit an add-on as a NEW add-on versus an UPDATE ro an existing add-on). Based on what I saw in my review there was NOTHING new, it looked like an UPDATE. (albeit an update based on incorrect data)

I get that you were trying to share and help the community, but you did this with little to NO explanation as to the changes you made when your mod was submitted (ALL of the documentation ckosloff and I wrote were included in your submission with no updates to the changelog at all). Your description of your add-on was identical to the original IH2 add-on with the only change being the VAGUEST of references to a "broken" feature.

You also NEVER stopped by this support thread to inform the community who uses Rev 7 of IH2 of your plans to update it. If you had, the members of the community who use Rev 7 surely would have told you (which is what occurred today) that the "broken feature" you were "fixing" was NEVER broken at all..

Now there are some who took exception to my pointing any of this out and thought I was giving you a hard time.. Not my intent. My concern was the confusion your version could cause. Because of how it was submitted, because the documentation was vague, and because it could cause confusion to the community. Not everyone will take the time to do an analysis to see what a NEW version REALLY brings to the table. Some community member will assume that if it's a NEW version, it must REALLY be new...

No worries.. However, I'm not sure what files you've been working off of.. Since the Rev 7 release neither ckosloff nor I have made any additional changes to the Rev 7 files.. What's available now is the same files that ckosloff compiled and submitted as Rev 7.

clydejones:

I'm also having no problems using Rev 7 of IH2 on my local test server using php5.3

Are you sure, as from memory imagehandler uses the ereg_replace function which is depreceated in php 5.3 so you should be getting an error

http://php.net/manual/en/function.ereg-replace.php

Actually come to think of it, have you perchance turned off error/warning reporting, as the functions are still in PHP (I Believe/think), but if the warnings are turned off they should work fine
however when the functions are removed Possibly next version of php it will fail,

as itys a local test server, would you mind trying step 2B here

https://www.zen-cart.com/tutorials/index.php?article=82

I might try it later but i have 2 preschoolers assisting me and until the ZenCart developers pull finger and ###### Bob the Builder to zencart i can't try it yet

DivaVocals:

His (my) lightbox and IH2 touch the same product page files. Since he did not merge these changes, his lightbox wiped out the IH2 code on his product page.

What product page files are you referring to? I just double-checked a directory compare of the two add-ons, and could find no overlapping files. (I was incorrect in what I said about main_product_image.php above.)

nigelt74:

Actually come to think of it, have you perchance turned off error/warning reporting, as the functions are still in PHP (I Believe/think), but if the warnings are turned off they should work fine
however when the functions are removed Possibly next version of php it will fail,

as itys a local test server, would you mind trying step 2B here

https://www.zen-cart.com/tutorials/index.php?article=82

I might try it later but i have 2 preschoolers assisting me and until the ZenCart developers pull finger and ###### Bob the Builder to zencart i can't try it yet

if you got this after the 1.3.9 upgrade then go to your cche folder and set its permissions to 777 or 755 on some servers

then go to the page again to see the blank page.

go back to the cache folder and open the file in there to see the error message, it may tell you what or where to start looking.

post it here for help.