Zen Cart Logo
Forums / Addon Admin Tools / Edit Orders v4.0 Support Thread

Edit Orders v4.0 Support Thread

Views: 345,911

Results 661 to 680 of 1,927
18 Dec 2014, 18:13
#661
lhungil avatar

lhungil

Totally Zenned

Join Date:
Feb 2012
Location:
mostly harmless
Posts:
1,818
Plugin Contributions:
4

Edit Orders v4.0 Support Thread

lat9:

... there are no tax-related calculations performed by the 1-time discount.
Correct. Taxes are handled by the order total for tax (ot_tax).

If you place the ot_onetime_discount sort_order before ot_tax, then the discount is pre-tax.
If you place the ot_onetime_discount sort_order after ot_tax, then the discount is post-tax.

18 Dec 2014, 18:42
#662
lhungil avatar

lhungil

Totally Zenned

Join Date:
Feb 2012
Location:
mostly harmless
Posts:
1,818
Plugin Contributions:
4

Re: Edit Orders v4.0 Support Thread

Please disregard the above post (timeout while editing - lost connection).

The "Onetime Discount" module was intended to be used when a store owner needs to offset the entire cost of an order due to a problem caused by humans at the store. For example failing to meet the expected shipping date. As such it does not alter the product pricing or taxes. It simply provides a simple way of handling issues caused by human error (the alternative workflow is creating "store credit" and applying it against the order).

The order total module ot_tax applies taxes based on product price, so you are correct. The tax will always reflect the tax rate against the product price listed in the order.

What is the situation requiring the order be discounted? Does the situation occur often? Can the store owner just move the sort_order to be after tax and add the amount of the tax to the actual discount they manually add?

Hopefully the above will work for the store's situation (I am curious about the situation, so examples are welcome). I'd also be receptive to contributed code adding "tax recalculation" to ot_onetime_discount (preferable checking if ot_tax is enabled, what the sort_orders of the two modules are, and if any other modules have already altered the pricing / tax).

19 Dec 2014, 13:07
#663
lat9 avatar

lat9

Administrator

Join Date:
Sep 2009
Location:
Stuart, FL
Posts:
14,065
Plugin Contributions:
56

Re: Edit Orders v4.0 Support Thread

The site is using the 1-time discount as a "quick and dirty" coupon. Both ot_onetime_discount (sort order 260) and ot_tax (sort order 300) are enabled. The site uses this feature often enough that they don't want to have to manually calculate the tax to be subtracted as well.

19 Dec 2014, 13:33
#664
lat9 avatar

lat9

Administrator

Join Date:
Sep 2009
Location:
Stuart, FL
Posts:
14,065
Plugin Contributions:
56

Re: Edit Orders v4.0 Support Thread

Oh my, that tax calculation does get complicated in the general case!:wacko: An order could contain a mixture of products with different tax rates (perhaps some taxed, some not) so simply recalculating the tax on the total doesn't work. Then there's the added complication of multiple tax rates being applied.

For my client, it's much simpler. A cart can include only one product and the (single) tax rate applied to that product is applied to the order's sub-total.

19 Dec 2014, 22:01
#665
lhungil avatar

lhungil

Totally Zenned

Join Date:
Feb 2012
Location:
mostly harmless
Posts:
1,818
Plugin Contributions:
4

Re: Edit Orders v4.0 Support Thread

lat9:

Oh my, that tax calculation does get complicated in the general case!:wacko: ...
Indeed it does :) Especially with the recent / upcoming changes and differing rules in different geographical regions.

I suppose in your client's case, a quick and dirty line to subtract the tax difference from the session variable holding the tax amount would work... Rather then trying to handle things generically and cover all possibilities...

Are the "coupons" applied to all customers? Select customers? Based upon a formula? Would one of "That Software Guys" discount modules work (these can do product level discounts and tax adjustments)?

19 Dec 2014, 22:43
#666
lat9 avatar

lat9

Administrator

Join Date:
Sep 2009
Location:
Stuart, FL
Posts:
14,065
Plugin Contributions:
56

Re: Edit Orders v4.0 Support Thread

lhungil:

Indeed it does :) Especially with the recent / upcoming changes and differing rules in different geographical regions.

I suppose in your client's case, a quick and dirty line to subtract the tax difference from the session variable holding the tax amount would work... Rather then trying to handle things generically and cover all possibilities...

Are the "coupons" applied to all customers? Select customers? Based upon a formula? Would one of "That Software Guys" discount modules work (these can do product level discounts and tax adjustments)?
The "coupons" applied are relatively haphazard, not applied to all and done post-customer-order-creation (so the swguy discounts won't apply).

21 Dec 2014, 22:29
#667
philibel avatar

philibel

Zen Follower

Join Date:
Mar 2008
Location:
Belgium
Posts:
120
Plugin Contributions:
3

Re: Edit Orders v4.0 Support Thread

Present:
Live shop running on ZC 1.5.1
Quantity Discounts 1.12
Edit Orders 4.0.4

Goal:
Live shop running on ZC 1.5.3
Quantity Discounts 1.12
Edit Orders 4.1.4

Which is the best way to upgrade?

  1. Upgrade to ZC 1.5.3 with edited files and then upgrade to Edit Orders 4.1.4
  2. Upgrade to Edit Orders 4.1.4 and then upgrade to ZC 1.5.3 with edited files
22 Dec 2014, 00:55
#668
philibel avatar

philibel

Zen Follower

Join Date:
Mar 2008
Location:
Belgium
Posts:
120
Plugin Contributions:
3

Re: Edit Orders v4.0 Support Thread

Philibel:

Present:
Live shop running on ZC 1.5.1
Quantity Discounts 1.12
Edit Orders 4.0.4

I'm sorry, it's 4.0.2

22 Dec 2014, 21:03
#669
lhungil avatar

lhungil

Totally Zenned

Join Date:
Feb 2012
Location:
mostly harmless
Posts:
1,818
Plugin Contributions:
4

Re: Edit Orders v4.0 Support Thread

Philibel:

Present:
Live shop running on ZC 1.5.1
Quantity Discounts 1.12
Edit Orders 4.0.4

Goal:
Live shop running on ZC 1.5.3
Quantity Discounts 1.12
Edit Orders 4.1.4

Which is the best way to upgrade? ...
Edit Orders 4.1.4 is compatible with both Zen Cart 1.5.1 and 1.5.3. Edit Orders 4.0.x is not compatible with Zen Cart 1.5.3. So, either the Edit Orders upgrade should be done first (may need to run the plugin installer after the Zen Cart upgrade) or the old version of Edit Orders removed before upgrading to Zen Cart 1.5.3.

I would recommend reading the following article (and supporting articles): How do I rebuild my site on the new version? Especially when upgrading to Zen Cart 1.5.3 from an older versions: starting with clean (no old files or modifications present) Zen Cart files* , upgrading the database, and rebuilding is less prone to errors (and faster for me).

*NOTE: When upgrading to Zen Cart 1.5.3, I would recommend applying the relevant fixes from the official Zen Cart 1.5.3 known bugs (and fixes) thread before running zc_install.

31 Dec 2014, 16:07
#670
jodean avatar

jodean

Totally Zenned

Join Date:
May 2011
Location:
Tennessee
Posts:
511
Plugin Contributions:
0

Re: Edit Orders v4.0 Support Thread

The download appears to be corrupt. When trying to unzip all I get an error while extracting. I then tried to unzip each folder one at a time. This works untill I reach the readme folder. The folders will unzip but the index.html will not extract. Does anyone have any ideas hoe I can work around this issue?

31 Dec 2014, 17:05
#671
divavocals avatar

divavocals

Totally Zenned

Join Date:
Jan 2007
Location:
Los Angeles, California, United States
Posts:
10,011
Plugin Contributions:
3

Re: Edit Orders v4.0 Support Thread

jodean:

The download appears to be corrupt. When trying to unzip all I get an error while extracting.** I then tried to unzip each folder one at a time.** This works untill I reach the readme folder. The folders will unzip but the index.html will not extract. Does anyone have any ideas hoe I can work around this issue?

Not having issues with the download.. Pretty sure this is a local computer issue for you.. Not completely clear what you mean when you say you are unzipping "each folder on at a time". Do you mean that you are extracting each individual folder?? What program are you using to unzip/extract the files?? It's POSSIBLE that the software you are using or HOW you are using it is at issue here.. Can you provide some more details??

02 Jan 2015, 17:17
#672
jodean avatar

jodean

Totally Zenned

Join Date:
May 2011
Location:
Tennessee
Posts:
511
Plugin Contributions:
0

Re: Edit Orders v4.0 Support Thread

DivaVocals:

Not having issues with the download.. Pretty sure this is a local computer issue for you.. Not completely clear what you mean when you say you are unzipping "each folder on at a time". Do you mean that you are extracting each individual folder?? What program are you using to unzip/extract the files?? It's POSSIBLE that the software you are using or HOW you are using it is at issue here.. Can you provide some more details??

I am using NCH Express UnZIP. Folders and files are extracted until it reaches the Index.html in the Readme folder. I found an old copy of the download and it works correctly. I considered using the old index.html with the new download but decided aginst it. I have attached an image of the Express Unzip with the error.Attachment 14829

02 Jan 2015, 18:50
#673
divavocals avatar

divavocals

Totally Zenned

Join Date:
Jan 2007
Location:
Los Angeles, California, United States
Posts:
10,011
Plugin Contributions:
3

Re: Edit Orders v4.0 Support Thread

jodean:

I am using NCH Express UnZIP. Folders and files are extracted until it reaches the Index.html in the Readme folder. I found an old copy of the download and it works correctly. I considered using the old index.html with the new download but decided aginst it. I have attached an image of the Express Unzip with the error.
Right.. Given that no one else has reported this issue, I believe the issue is with your Unzip program.. May I suggest you try using a different one 7-Zip is a good trouble-free unzipping program..

ETA: JUST downloaded Edit Orders and had NO ISSUES whatsoever extracting the files using 7-Zip..

19 Jan 2015, 08:06
#674
sweettraders avatar

sweettraders

New Zenner

Join Date:
Nov 2008
Posts:
11
Plugin Contributions:
0

Re: Edit Orders v4.0 Support Thread

**Blank store page **after installing Edit Orders V4.0 on Zen Cart 1.5.1
Our PHP Version: 5.2.17 (Zend: 2.2.0) and Database: MySQL 5.0.96-log
Fatal error log

[18-Jan-2015 22:59:29] PHP Warning:  include_once(includes/modules/shipping/ups.php) [<a href='function.include-once'>function.include-once</a>]: failed to open stream: No such file or directory in /store/includes/classes/shipping.php on line 68
[18-Jan-2015 22:59:29] PHP Warning:  include_once() [<a href='function.include'>function.include</a>]: Failed opening 'includes/modules/shipping/ups.php' for inclusion (include_path='.:/usr/local/php5/lib/php') in /store/includes/classes/shipping.php on line 68
[18-Jan-2015 22:59:29] PHP Fatal error:  Class 'ups' not found in /store/includes/classes/shipping.php on line 70

Warning

[18-Jan-2015 22:59:26] PHP Warning:  Cannot modify header information - headers already sent by (output started at /store/kladmin/includes/languages/english/orders.php:135) in /store/kladmin/includes/init_includes/init_templates.php on line 55

Even after following the uninstall steps the store page is still blank. I've also restored the backup files and the store page is still blank.
This is only a live site. I followed instructions of several threads on debugging blank pages over the last 24 hours without any luck. Reached out to host GoDaddy who will restore my site going back 48 hours. Will take 3-4 days before they get to it though. There goes my Valentine orders and google ranking.
Any advice on debugging this will be greatly appreciated.

19 Jan 2015, 08:46
#675
divavocals avatar

divavocals

Totally Zenned

Join Date:
Jan 2007
Location:
Los Angeles, California, United States
Posts:
10,011
Plugin Contributions:
3

Re: Edit Orders v4.0 Support Thread

sweettraders:

**Blank store page **after installing Edit Orders V4.0 on Zen Cart 1.5.1
Our PHP Version: 5.2.17 (Zend: 2.2.0) and Database: MySQL 5.0.96-log
Fatal error log

[18-Jan-2015 22:59:29] PHP Warning: include_once([B]includes/modules/shipping/ups.php[/B]) [<a href='function.include-once'>function.include-once</a>]: failed to open stream: [B]No such file or directory [/B]in /store/includes/classes/shipping.phpon line 68
[18-Jan-2015 22:59:29] PHP Warning: include_once() [<a href='function.include'>function.include</a>]: [B]Failed opening 'includes/modules/shipping/ups.php[/B]' for inclusion (include_path='.:/usr/local/php5/lib/php') in /store/includes/classes/shipping.php on line 68
[18-Jan-2015 22:59:29] PHP Fatal error: Class 'ups' not found in /store/includes/classes/shipping.php on line 70

> **Warning**
> ```
[18-Jan-2015 22:59:26] PHP Warning:  Cannot modify header information - headers already sent by (output started at /store/kladmin/includes/languages/english/orders.php:135) in /store/kladmin/includes/init_includes/init_templates.php on line 55

Even after following the uninstall steps the store page is still blank. I've also restored the backup files and the store page is still blank.
This is only a live site. I followed instructions of several threads on debugging blank pages over the last 24 hours without any luck. Reached out to host GoDaddy who will restore my site going back 48 hours. Will take 3-4 days before they get to it though. There goes my Valentine orders and google ranking.
Any advice on debugging this will be greatly appreciated.

Did you try reinstalling your UPS shipping module??? Because your errors would seem to indicate that THIS is where the issue lies..

19 Jan 2015, 15:25
#676
sweettraders avatar

sweettraders

New Zenner

Join Date:
Nov 2008
Posts:
11
Plugin Contributions:
0

Re: Edit Orders v4.0 Support Thread

DivaVocals:

Did you try reinstalling your UPS shipping module??? Because your errors would seem to indicate that THIS is where the issue lies..

Yes tried the UPS module reinstall. No luck. This Edit Order module really messed things up. Paid the $80 to Godaddy to restore files. (not the database, that will be another $80) and store is working again.

19 Jan 2015, 15:36
#677
mc12345678 avatar

mc12345678

Totally Zenned

Join Date:
Jul 2012
Posts:
16,908
Plugin Contributions:
2

Re: Edit Orders v4.0 Support Thread

sweettraders:

Yes tried the UPS module reinstall. No luck. This Edit Order module really messed things up. Paid the $80 to Godaddy to restore files. (not the database, that will be another $80) and store is working again.

Unfortunate that the 1) the freely available backup before attempting installation wasn't performed and 2) that the install was attempted on a live site without any previous attempt/backup/verification... All of this cautionary information is addressed in the instructions and throughout this site and forum... http://www.zen-cart.com/entry.php?3-How-do-I-rebuild-my-site-on-the-new-version-instead-of-upgrading
But would think the cost of the restore at this point is minor compared to that of not doing business...

20 Jan 2015, 00:05
#678
divavocals avatar

divavocals

Totally Zenned

Join Date:
Jan 2007
Location:
Los Angeles, California, United States
Posts:
10,011
Plugin Contributions:
3

Re: Edit Orders v4.0 Support Thread

sweettraders:

Yes tried the UPS module reinstall. No luck. This Edit Order module really messed things up. Paid the $80 to Godaddy to restore files. (not the database, that will be another $80) and store is working again.

I doubt it was the Edit Orders module.. the MOST likely cause of issues with this module usually are as a result of installation errors.. Besides your error logs would tend to indicate that this is another issue altogether..

Suggest backing up, and creating a development version of your store, and do your install there FIRST to test and work out the issues.. Just posted this same advice for another user who seemed to think I was picking on him (his words were I should "run my site the way I want":laugh: shrug.. Anyway I say this to you as well as this advice comes from YEARS of experience which is why MANY of us frequently say it.. It ensures that you have a lesser chance of taking down your live store..

20 Jan 2015, 15:50
#679
michaelchu avatar

michaelchu

Zen Follower

Join Date:
Nov 2011
Posts:
121
Plugin Contributions:
0

Re: Edit Orders v4.0 Support Thread

Any chance this can be made fully compatible with 1.5.4 soon?

20 Jan 2015, 16:11
#680
lhungil avatar

lhungil

Totally Zenned

Join Date:
Feb 2012
Location:
mostly harmless
Posts:
1,818
Plugin Contributions:
4

Re: Edit Orders v4.0 Support Thread

sweettraders:

... ```
[18-Jan-2015 22:59:29] PHP Warning: include_once(includes/modules/shipping/ups.php) [<a href='function.include-once'>function.include-once</a>]: failed to open stream: No such file or directory in /store/includes/classes/shipping.php on line 68
[18-Jan-2015 22:59:29] PHP Warning: include_once() [<a href='function.include'>function.include</a>]: Failed opening 'includes/modules/shipping/ups.php' for inclusion (include_path='.:/usr/local/php5/lib/php') in /store/includes/classes/shipping.php on line 68

> ...
As indicated by the error messages, Zen Cart was unable to load your UPS shipping module (probably from the admin). Note the lack of "/store/" in front of the path to this file. The usual causes listed in this thread are:
- The two required patches were not successfully applied to "/store/includes/classes/shipping.php" (or the installation step was skipped).
- Misconfiguration of filesystem paths in one or both of the "configure.php" configuration files.


> **sweettraders:**
>
> ... ```
[18-Jan-2015 22:59:26] PHP Warning:  Cannot modify header information - headers already sent by (output started at /store/kladmin/includes/languages/english/orders.php:135) in /store/kladmin/includes/init_includes/init_templates.php on line 55
```...
This indicates there is a problem with the file at: "/store/kladmin/includes/languages/english/orders.php". This file is a language file used by the Zen Cart admin. Most likely a mistake made when applying the required patch or editing the file to change verbiage. There is a good article on this site about how to debug [warning headers already sent](http://www.zen-cart.com/content.php?129).