Edit Orders v4.0 Support Thread

Well, I'm extremely frustrated.

I followed your directions and

• Uploaded and overwrote orders.php file in my admin folder with the stock Zencart 1.51 file

• The version of TY is 3.1.1 which is apparently the latest but I uploaded and overwrote all the files anyway. It seems to be OK on its own and the admin screen under configuration kept my previous settings.

• installed the latest version of Super Orders (4.0.9) next although the Super Orders instructions suggest to install Edit Orders first. Installation directions refer to "2_Modified_Core_Files" There are actually folders labeled 2a_Modified_Core_Files and 2b_Modified_Core_Files-COWOA so I uploaded both. I have no idea what the "COWOA" may refer to and I couldn't find the term in the instructions. The resulting screens in my admin looked normal and I got the new buttons. Strange thing is on the bottom of the Super Orders configuration screen it lists the version as 4.0.5

• I now installed Edit Orders (4.1.4) and did not upload the orders.php file in 1_modified_core_files as per the integration instructions for use with Super Orders. I logged into admin prior to uploading the install files and the script apparently ran giving me the light green bar of success after clicking on a link. "Found previous version installed. Upgrading (or re-installing) Edit Orders (old 4.1.4 => new 4.1.4).
  Success Edit Orders installation / upgrade completed!"

I did not perform any file mergers as I don't believe that I have any other order related plug-ins

End result:

I still have the "HEADING_TITLE_ORDERS_LISTING" above my orders list
I still have the "HEADING_TITLE_ORDER_DETAILS562" above the details of an individual order

Clicking on either EDIT button now brings me "WARNING: An Error occurred, please refresh the page and try again." on an otherwise blank page. The resulting URL's are: From the orders details page for order number 562: "mysite/myadmin/edit_orders.php?oID=562" and from the orders list: "edit_orders.php?page=1&oID=562&action=edit"

I very much appreciate assistance

landron:

...

• installed the latest version of Super Orders (4.0.9) next ... Installation directions refer to "2_Modified_Core_Files" There are actually folders labeled 2a_Modified_Core_Files and 2b_Modified_Core_Files-COWOA so I uploaded both. ...
  If I remember correctly (I think it was a discussion somewhere in the Zen Cart forums), "Super Orders" contains modified files for a stock installation of Zen Cart 1.5.0/1.5.1 in the "2_Modified_Core_Files" folder (these should be applied when installing "Super Orders"). "2b_Modified_Core_Files-COWOA" contains merges for integration with CheckOut WithOut Account (and should only be applied if the COWOA module is installed).

As for the version number being "off", the last person to upload "Super Orders" probably forgot to update the version number. I would not worry about that too much (as long as it reports >= 4.0.5).

landron:

...
I still have the "HEADING_TITLE_ORDERS_LISTING" above my orders list
I still have the "HEADING_TITLE_ORDER_DETAILS562" above the details of an individual order
..
This indicates the language files for "Super Orders" were not installed in the correct location, the upload was corrupted, or the administrative interface is not in English. In particular: "/2a_Modified_Core_Files/YOUR_ADMIN/includes/languages/english/orders.php" will need to be uploaded to "/admin/includes/languages/english/orders.php" (or if using Spanish in the Zen Cart administrative interface to "/admin/includes/languages/spanish/orders.php").

This is not something caused by "Edit Orders". I would double check the files uploaded during the installation of "Super Orders" especially the language files.

landron:

...

• I now installed Edit Orders (4.1.4) and did not upload the orders.php file in 1_modified_core_files as per the integration instructions for use with Super Orders. I logged into admin prior to uploading the install files and the script apparently ran giving me the light green bar of success after clicking on a link. "Found previous version installed. Upgrading (or re-installing) Edit Orders (old 4.1.4 => new 4.1.4).
  Success Edit Orders installation / upgrade completed!"

...

Clicking on either EDIT button now brings me "WARNING: An Error occurred, please refresh the page and try again." on an otherwise blank page. ...
A step in the right direction! Now we are no longer getting a "HTTP 404", so the page exists. And "Super Orders" has the correct link!

When one encounters "WARNING: An Error occurred, please refresh the page and try again.", this indicates an error occurred. Please post the contents of the debug log generated by Zen Cart (needed to further troubleshoot). Use a "code" block when posting (click the # in the editor) so we can more easily read the contents.

NOTE: The most common causes for seeing the above message when loading the "Edit Orders" administrative page are: skipped / incorrect merges to core Zen Cart files during installation step 1 of "Edit Orders", third party "Order Total Modules" installed (which cause errors when loaded from the administrative side of Zen Cart), and corrupt order data (caused by 3rd party access / manipulation of the Zen Cart database).

OK; after researching and realizing that the COWOA files in Super Orders didn't apply to me, I deleted them from the server and re-uploaded the base and 2a Modified files in attempting to invoke the install script. No script ran even though I was logged into admin and then clicked a link. Headings all look proper now. Hitting the Edit button now brings me to an edit screen where I can edit most aspects of the order. However, clicking "update" results in "WARNING: An Error occurred, please refresh the page and try again." on an otherwise white page. Hitting back on my browser brings back the edit screen and my changes were saved for all customer info but not the dollar amounts.

Adding products brings me to a product selection screen but after selecting a product and clicking "Add Now", I get a completely white screen; not even an error message. Hitting my back button on my browser a few times brings me back to the edit order screen and the new product is now included although the Sub-Total and Total dollar amounts do not reflect the addition. I certainly wouldn't mind manually entering new dollar amounts as shipping would also change but the new amounts that I entered do not get saved. Some progress but not quite there yet.

landron:

OK; after researching and realizing that the COWOA files in Super Orders didn't apply to me, I deleted them from the server and re-uploaded the base and 2a Modified files ... Headings all look proper now. Hitting the Edit button now brings me to an edit screen where I can edit most aspects of the order. However, clicking "update" results in "WARNING: An Error occurred, please refresh the page and try again." ...
When one encounters "WARNING: An Error occurred, please refresh the page and try again.", this indicates an error occurred. Please post the contents of the debug log generated by Zen Cart (needed to further troubleshoot). Use a "code" block when posting (click the # in the editor) so we can more easily read the contents.

NOTE: The most common causes for seeing the above message when loading the "Edit Orders" administrative page are: skipped / incorrect merges to core Zen Cart files during installation step 1 of "Edit Orders", third party "Order Total Modules" installed (which cause errors when loaded from the administrative side of Zen Cart), and corrupt order data (sometimes caused by 3rd party access / manipulation of the Zen Cart database).

Found a switch to turn on debugging in Edit Orders config screen. I can only hope that is is what you mean as it did produce a log file after setting it to "Product" which resulted in a "4" on the config screen. Here's the file:

[05-Dec-2014 16:00:09 America/New_York] PHP Fatal error:  1054:Unknown column 'p.products_quantity' in 'field list' :: SELECT `p`.`products_quantity` FROM `products` WHERE `p`.`products_id` = '1424' in /home2/onlinio3/public_html/includes/classes/db/mysql/query_factory.php on line 120

I located the bug and fix in lines 1025 - 1028 of the edit_orders_functions.php in numerous posts here and made the change. Still wind up with blank screens.

landron:

I located the bug and fix in lines 1025 - 1028 of the edit_orders_functions.php in numerous posts here and made the change. Still wind up with blank screens.

Again.. blank/white/empty screens means that an error log was created in the "logs" folder of your site... PLEASE post the contents of these error logs so we know what the error is... It's the only way we have ANY clue what is going on.. Use a "code" block when posting (click the # in the editor) so we can more easily read the contents.

mvstudio:

Hello Everyone!
Great mode, but I'm having an issue I seem not to find the answer for.
Clean ZC 1.5.1 install, with Super Orders and Edit Orders 4.1.4, + other modules.

In edit orders, adding a discount coupon on an order without taxes, the total is calculated correctly.
However, adding a discount coupon on an order with taxes, the total is calculated incorrectly. Everything else works fine, with every scenario, except this.
Has anyone encountered this before? Can someone point me in the right direction to figure this one out?
Thanks a bunch for the help!

first off, i want to say that this module is shareware... i never paid for it, so the idea that we can make demands on the developer seems a bit lame to me...

i stand by my previous comment about deleting and re-adding items in the orders products table. no developer can for-see everything going on in other users implementations. but as i said previously i do not agree with that decision.

with the comments above, i am experiencing the same situation. i have ot_tax records from the orders_total table getting deleted; and adding products after a coupon has already been established does not re-calculate the coupon value nor does it accurately recalculate the tax.

i have yet to really dig into these issues, but i no doubt will. i'm sure there were reasons why this module was designed the way that it is, but unfortunately for me, there are SO many problems that i have a difficult time with recommending it. perhaps i will find an easy fix, but TAX not getting calculated correctly? discount coupons that do not update when you add new products?

i know editing an order affects a number of different tables, but frankly i'm really at a loss on this code. and i do not remember this level of problems with the super-orders module; but hey that was a long time ago when i implemented that.

landron:

I located the bug and fix in lines 1025 - 1028 of the edit_orders_functions.php in numerous posts here and made the change. Still wind up with blank screens.

Please list every installed Order Total module "admin"->"modules" -> "order total".
If the order contains shipping please list the "shipping module" for the order.
Please provide any newer debug logs.

carlwhat:

first off, i want to say that this module is shareware. ...
First, this module is not shareware. For the record, Edit Orders is licensed under GPL.

As you point out people are using Edit Orders for free. To date I have not received a single donation to help cover any of my time: updating this module (when new versions of Zen Cart 1.5.x are released), to fix bugs, to add wider compatibility, or for providing support here on the Zen Cart forums. I wish I had more "free" time to donate!

I enjoy working with the awesome Zen Cart contributors and development team. But in the end, I do need to pay the bills - so my "day" job takes precedence. Thank You to everyone (including carlwhat) who understands this basic fact.

carlwhat:

...i stand by my previous comment about deleting and re-adding items in the orders products table. no developer can for-see everything going on in other users implementations. but as i said previously i do not agree with that decision. ...
To avoid potential clashes when updating a product in the database, products which are modified are first removed. This is a carryover from a previous version of Edit Orders. It currently affects less than 1% of the people who install this module. As posted earlier, that 1% can alter the behavior by applying the same changes they made to the store front.

The code changes in the last few versions now track most of the database indexes (stock Zen Cart catalog files do not). Now that we are tracking them, it becomes possible for a future release to simply update the associated records instead of removing all and rebuilding the order. This has been applied to the "Order Total" module handling already and may in the future be added to the product, product attribute, and product download handling.

Personally, I believe the best long term solution is to revamp the internal Zen Cart code handling the shopping cart and order process (the long awaited and anticipated Zen Cart 2.0 will probably contain these changes). But in the meantime, everything needs to stay compatible with the officially supported versions of Zen Cart (and as you probably have noticed I tend towards longer QA testing before releasing new versions of modules I am maintaining).

carlwhat:

... adding products after a coupon has already been established does not re-calculate the coupon value nor does it accurately recalculate the tax. ...
Can you try clicking the "update" button after adding the products? I believe this is the current workaround until I can find time to address the root cause.

carlwhat:

... i know editing an order affects a number of different tables, but frankly i'm really at a loss on this code. and i do not remember this level of problems with the super-orders module; but hey that was a long time ago when i implemented that.
"Super Orders" != "Edit Orders". They have been different modules for quite awhile now.

I personally remember far more issues when using the older versions of Edit Orders (3.x and 4.0). It regularly produced tax errors, corrupted data (or data formats) in the various order related tables, failed to validate inputted data, did not use the order total modules to process the order totals, etc. The old versions also did not provide the best user experience for an administrative user. For example: no dropdowns to use when selecting order total modules, no way to search when adding a product, did not automatically apply coupons or low order fees, and did not attempt to detect / notify / correct various error conditions.

mvstudio:

... adding a discount coupon on an order with taxes, the total is calculated incorrectly. Everything else works fine, with every scenario, except this. ...
Can you provide exact steps starting before the order exists all the way through to editing the order? This will better help me understand what you mean by "the total is calculated incorrectly" and where things may have gone wrong.

Have you applied any modifications to Zen Cart's handling of taxes such as "TaxCloud" or a "VAT module"?

Any debug logs (post inside code blocks - use the # in the editor)? Even if these appear unrelated they may be useful.

What are the sort orders for your order total modules? What are the settings for the coupon order total module (ot_coupon)? These are vital to help duplicate your store setup.

What are the settings for the specific coupon?

ShopVille:

Hi TIA.
My store is using text attributes with multiple lines of text, when editing a order the attribute looses the line breaks and combines into one line without spaces, is there any fix for it to keep the formatting?

Perhaps this can help?
https://www.google.ca/search?safe=active&output=search&sclient=psy-ab&q=sql%20database%20maintain%20line%20breaks&oq=&gs_l=&pbx=1&bav=on.2,or.r_cp.r_qf.&bvm=bv.80642063,d.eXY&ion=1&biw=1920&bih=955&ech=1&psi=ulWGVPXSH8GgNqymhKgL.1418089916973.3&ei=ulWGVPXSH8GgNqymhKgL&emsg=NCSR&noj=1&gws_rd=ssl

ShopVille:

... Text Attributes multiple lines of text ...
As long as the attribute is configured correctly in Zen Cart (to allow multiple lines), these work in both Zen Cart and Edit Orders...

If you are experiencing issues, please post related details including attribute settings (option names, values, product attribute, debug logs, modifications to attribute handling, etc).

Has anyone ever run into an order that wouldn't update? This is in a 1.3.9h cart where editing orders has not been a problem. This one very large order is now missing the name and address info after attempting to update. After hitting the update button, the url remains the same but the screen refreshes and shows the home page of the site. The quantities do not update. There has to be over 50 line items with a few attributes.

The order was entered in with logon as customer which also hasn't been an issue before. Site has been up and working since 2012 with no issues.

I've been trying to get them to upgrade so in the end that's what we'll probably have to do and hope the problem goes away. Just wondering if anyone had had this happen to them.

lhungil:

I personally remember far more issues when using the older versions of Edit Orders (3.x and 4.0). It regularly produced tax errors, corrupted data (or data formats) in the various order related tables, failed to validate inputted data, did not use the order total modules to process the order totals, etc. The old versions also did not provide the best user experience for an administrative user. For example: no dropdowns to use when selecting order total modules, no way to search when adding a product, did not automatically apply coupons or low order fees, and did not attempt to detect / notify / correct various error conditions.nods in agreement:yes: as the person who took on maintaining the older versions of Edit Orders when the original developer stepped away, there was a "known issues" thread I posted which listed all of these issues. Thank GOODNESS you came along and took this dog with fleas off my hands and gave her a MUCH NEEDED flea bath!!:laugh: The difference has been night and day, and those of use who rely on this module have been grateful. As you stated, this module works on 99% of the stores out there with NO ISSUES what so ever!! So kudos to you.. and a donation from my client who uses and can't live without this module is coming before the end of the year!! (yeah I did browbeat him in a GOOD way into it!!:laugh: he wanted me to pass on his gratitude to you!!)

mvstudio:

Hello Everyone!
Great mode, but I'm having an issue I seem not to find the answer for.
Clean ZC 1.5.1 install, with Super Orders and Edit Orders 4.1.4, + other modules.

In edit orders, adding a discount coupon on an order without taxes, the total is calculated correctly.
However, adding a discount coupon on an order with taxes, the total is calculated incorrectly. Everything else works fine, with every scenario, except this.
Has anyone encountered this before? Can someone point me in the right direction to figure this one out?
Thanks a bunch for the help!

i have found many issues with regards to this module. and it is very sensitive to the order in which someone edits an order. i have found entering a discount code only AFTER having completed all item entry/modification to be the only way to get it to work.

as previously stated by lhungil (i think), one needs to hit update twice when processing an order with discounts and taxes.

as mvstudio (and i) ran into a problem with regards to the correct calculation of orders with discounts and taxes, the problem starts with the 3rd (and future) times one hits enter. then the totals all go off...

i have tracked down this problem (at least as it relates to me) to the function eo_update_database_order_totals and specifically when it updates the ot_coupon. the ot_coupon will continue to subtract the taxable amount of the discount even if it has already done it before.

i was able to resolve this problem by the following "hack" in the ot_coupon module. i changed this code:

  if (DISPLAY_PRICE_WITH_TAX != 'true') {
      $order->info['total'] -= $tax;
  }

to:

  if (DISPLAY_PRICE_WITH_TAX != 'true') {
    // fix for admin side of edit orders
    if (!isset($_SESSION['coupon_amount']) && (IS_ADMIN_FLAG == false)) {
      $order->info['total'] -= $tax;
      $_SESSION['coupon_amount'] = $od_amount['total'];
    }
  }

the IS_ADMIN_FLAG is necessary so that orders entered by customers are not affected. and the variable is $_SESSION['coupon_amount'] is really just a flag here, as opposed to needing that amount down the line.

hope that helps someone. no guarantees or implied warranties or anything else....

delia:

... This is in a 1.3.9h cart where editing orders has not been a problem. ...
Edit Orders 4.x is not intended for use under Zen Cart 1.3.x, so would not be surprised if problems occurred. This goes doubly for Edit orders 4.1+ as it contains some functions from Zen Cart 1.5.x and directly utilizes the Zen Cart 1.5.x classes and functions to display, edit, and update the order.

Perhaps the site is using one of the older versions for Zen Cart 1.3.x such as Edit Orders 3.x (no longer actively maintained or supported)?

delia:

... I've been trying to get them to upgrade so in the end that's what we'll probably have to do and hope the problem goes away. ...
Sounds like a good plan. Keep us up to date!

delia:

... Has anyone ever run into an order that wouldn't update? ... Just wondering if anyone had had this happen to them.
I ran into similar issues on occasion in the older versions of Edit Orders. With Edit Orders 4.1.x (under Zen Cart 1.5.x), I have rarely seen the same behavior reported.

The most common causes under Zen Cart 1.5.x with Edit Orders 4.1.x are one or more of the following:

• Third party order total modules (crashing when loaded from the Zen Cart admin)
• Core file merges not applied correctly
• Corrupt or missing database records
• Known bugfixes not applied to the latest version
  Usually a quick look at the Zen Cart debug logs will provide a nudge in the right direction.

Running EO 4.1.4 on ZC 1.5.1. The ot_onetime_discount module is enabled with sort-order 260 and ot_tax is enabled with sort-order 300. When a 1-time discount is applied to an order, the tax is not recalculated.

Any ideas? I thought I'd post here before I head off to see what's up in the code.

lat9:

Running EO 4.1.4 on ZC 1.5.1. The ot_onetime_discount module is enabled with sort-order 260 and ot_tax is enabled with sort-order 300. When a 1-time discount is applied to an order, the tax is not recalculated. ...
Strange since tax processing is not done directly by Edit Orders (handed off to Order Total classes).

Is VAT involved (I remember discussions in the past related to VAT, but was not able to duplicate in a stock Zen Cart or get enough info on modifications to test)?

Have you tried pressing the "update" button a second time (to retrigger calculation by the order total modules)? Anything jumping out when enabling debug "order totals"?

No VAT, just regular US taxes. I also tried the double-update trick ... no go.

Update: Unlike the coupon processing (where tax can optionally be recalculated), there are no tax-related calculations perofmred by the 1-time discount.