So I tested this patch last night.. In addition to this patch not being PHP 5.3 compatible, the section which explains the change needed to get the zoom effect to work on medium images breaks my product detail pages.
In addition (as I have always maintained), there is specific code in this patch which appears to be in direct conflict with nearly all lightbox contributions..
With regards to zooming on medium images, IMO, it makes sense that perhaps this "non-working" feature should probably be "removed" in the next IH2 release.. This will eliminate ANY confusion on this matter for users of this mod. I am working on a PHP 5.3 compatible version of IH2 and if I am able to finish this release, I will be removing this setting from the IH2 admin.
Now if there is anyone who has WORKING PHP 5.3 compatible code which gets zoom to work on medium images AND does not interfere with lightbox contributions, hopefully they will be willing to share their code with the community.. I haven't found anything else that includes any specific code other than the patch post..
DivaVocals:
So I've been looking over this post:
http://www.zen-cart.com/forum/showpost.php?p=489431&postcount=2147
And I may take another look at this again.. It's been long established that the hover effect does not work on medium images, and it's MORE than clear that not everyone understands how to set image sizes correctly to get everything working in IH2.. I'll gladly admit that I have a spreadsheet and cheat notes to help me with setting up images, and even with that I didn't really KNOW why certain things worked.. I just knew they "did"..
So anyway back to this post, I think that MINUS this change:
many (perhaps not all) of capnhairdo's changes could be SAFELY incorporated into the IH2 code.. I will look at this with Beyond Compare tonight.. and if the spirit (and my time availability) moves me I'll try testing these changes on my test store..
The capnhairdo's changes to the main_product_image template however are in DIRECT conflict with lightbox and other similar mods, I would need to evaluate what other files in this "patch" might also be in conflict with a lightbox mod.. I may even give a shot to figuring out how to incorporate his main_product_image changes to work with Fual Slimbox (if I do this, I won't be tackling any other lightbox mods as I don't use them..)