Image Handler 2 (for ZC v1.3.8 ONLY) Support

@DV

I know the rhetoric is more now than what is deserved.

However, I would ask that you look again at what I posted about the classic template "problem."

As I said, I'm well aware of what *should be *done with the classic template. What I'm pointing out is what is happening when someone uses classic template, 1.3.9c, and IH2 8c.

As you know, Zen Cart should look to the template_default tpl's if none is found in the current template. For some reason, it is not in this case. Maybe Zen Cart is not set to look to template_default for additional stylesheets. It would seem it is not looking for this stylesheet.

I don't know where the "problem" lies, but an addition of the classic/css/style_imagehover.css to the mod files might keep one less "It don't work" out of the forum certainly easier than coding the files to look in the default if the stylesheet is not found in the current template.

See http://tinyurlDOTcom/366mbdl for an example. You'll find that Fual Slimbox is running, but the same thing happened before it was installed.

dbltoe:

@DV

I know the rhetoric is more now than what is deserved.

However, I would ask that you look again at what I posted about the classic template "problem."

As I said, I'm well aware of what *should be *done with the classic template. What I'm pointing out is what is happening when someone uses classic template, 1.3.9c, and IH2 8c.

As you know, Zen Cart should look to the template_default tpl's if none is found in the current template. For some reason, it is not in this case. Maybe Zen Cart is not set to look to template_default for additional stylesheets. It would seem it is not looking for this stylesheet.

I don't know where the "problem" lies, but an addition of the classic/css/style_imagehover.css to the mod files might keep one less "It don't work" out of the forum certainly easier than coding the files to look in the default if the stylesheet is not found in the current template.

See http://tinyurlDOTcom/366mbdl for an example. You'll find that Fual Slimbox is running, but the same thing happened before it was installed.

What you are describing happens no matter which template you happen to be using when the IH2 stylesheet is missing.

@Clyde,

Yes, that's why I am suggesting adding the stylesheet to the classic/css in the mod download.

Possibly adding "Make sure style_imagehover.css is in your current template's css folder." to the "Other Troubleshooting Tips" will help as I did not find it when I first noticed the "problem."

I realize you can't make something "idiot proof", but you can try to anticipate some of their mistakes and head them off at the pass.

clydejones:

What you are describing happens no matter which template you happen to be using when the IH2 stylesheet is missing.Exactly..

dbltoe:

@Clyde,

Yes, that's why I am suggesting adding the stylesheet to the classic/css in the mod download.

Possibly adding "Make sure style_imagehover.css is in your current template's css folder." to the "Other Troubleshooting Tips" will help as I did not find it when I first noticed the "problem."

I realize you can't make something "idiot proof", but you can try to anticipate some of their mistakes and head them off at the pass.What you are stating isn't quite true..
There are two template specific folders in the Rev8c fileset

1. /includes/modules/YOUR_TEMPLATE
2. /includes/templates/YOUR_TEMPLATE
   Renaming both of these folders to the name of your template for ANY template (including classic) should add the IH2 files to a template folder for your template..

and in the readme it clearly says that you MUST rename the YOUR_TEMPLATE folders to the name of your template's folder (like in other modules for example Fual Slimbox)

Renaming the /includes/templates/YOUR_TEMPLATE folder to ** /includes/templates/classic** ADDS the style_imagehover.css to the classic template.. I'm not entirely sure I understand why you think this is not so..

how do i add water marks

nateberry:

how do i add water marks

From the IH2 readme file

Watermarking
In order for watermarking to work for every image dimension the specific corresponding watermark images have to be present. That means, you have to upload files to the following specific locations (these are included in the install package):

* images/watermark.png
* images/medium/watermark_MED.png (or your specified MEDIUM_IMAGE_SUFFIX)
* images/large/watermark_LRG.png (or your specified LARGE_IMAGE_SUFFIX)

The add-on package includes some demo watermark images for small, medium and large sized images featuring a slightly modified Zen-Cart logo for a quick start. Nothing more to do, switch on, switch off, just as you like. Image Handler takes care of generating images accordingly. You can specify where you want the watermark to appear on the image canvas by selecting NorthWest, North, NorthEast, West, Center, East, SoutWest, South and SouthEast for the Watermark Gravity setting.

I never said it was not so.

I simply stated that a newly installed, unmodified 1.3.9e would not work "properly" with the classic template unless the user KNEW to rename the your_template in the installation or add style_imagehover.css to the classic/css folder.

We all see everyday evidence that people have the impression that your_template, custom, or custom_template means something OTHER THAN classic.

I merely suggested that the style_imagehover.css be placed in Zen from the installation by adding classic/css/style_imagehover.css to the templates folder of the install. No core files would be touched and, to me, that would cover the user's assumption that classic does not need to be changed.

And... How many times have you said or heard, "Does it work when you switch to the classic template?"

I presume there are other IH2 files under /includes/templates/your_template/, so failing to rename that folder would cause all those features to not work, not just the stylesheet.

Glenn,

The reason I added to this thread and opened another thread on defaulting stylesheets is that I had the same presumption as you until I tested this in 1.3.9e with classic.

Like you, I PRESUMED that the css would be picked up in the same manner as define_main_page.php or tpl_login_default.php.

However, unlike folders such as buttons, common, templates, etc., the css directory is NOT defaulted to any other directory than the current selected by the admin.

And a "cold load" of the add-on will load the "default-abled" filetypes to the template_default as you pointed out. So (again)... Brand spanking new 1.3.9c -- load IH2 -- run shop -- IH2 works incorrectly. It finds every file BUT the stylesheet.

After looking at the readme and doing some research, I offered the inclusion of the stylesheet to the classic template as a possible preventive measure to stop a few "it don't work" comments.

I can't get this to work.

First the medium watermark didn't show up. Then it did. So did the zoom. Now the watermark is gone again, although it's still there on medium images, but the zoom is gone from everywhere but the review images? And the large watermark never worked at all?

What's up with all this?

tpeck:

Why not be helpful without the attitude, like clydejones?
I have a reputation of arrogance and rudeness to maintain.

DivaVocals:

Additionally I am of the opinion that "fixing" the IH2 code to allow for these symbols to be used in files names is an inherently BAD idea. Perhaps some of the developers who post here could weigh in on this thought.
Diva Darling,
Goodness gracious!
Allowing for special characters that are used in our cherished Unix systems to be used in file names?
That would mean an aberrant mix between plebeian files and our noble kernel files, horrid spawns would ensue, often called "errors".
Arrogantly and pompously yours,
ckosloff

And it does, it means re-name those folders to match your template's folder name. I understand the intent, but it is spelled out in the readme.

I would like to make this BULLETPROOF for everyone, but that is what we have done by including a comprehensive readme, and that is what these support threads are for. We are trying to make this module broad based like any other modules have done in how they handle template specific folders. (IH2 is not the only module to not have a specific "classic" template folder)

dbltoe:

We all see everyday evidence that people have the impression that your_template, custom, or custom_template means something OTHER THAN classic.

You might want to have a look at the download fileset you got from my site.. (suggest downloading again) There should not be a default_template or classic template specific set of folders (the default_template folders in particular never should have been a part of IH2)

From the readme file:

• (Rev 8b) Corrected the following files based on current version of Zen Cart:

• admin/includes/modules/category_product_listing.php

• includes/modules/additional_images.php

• (Rev 8b) Moved the following files to the correct Zen Cart override folders:

• includes/modules/main_product_image.php

• includes/modules/additional_images.php

• (Rev 8b) The following files were deleted from the install package (they are now obsolete)

• images/zoom.png

• images/medium/zoom_MED.png

• images/large/zoom_LRG.png

• includes/template/default_template

• includes/template/classic (if you are using the Classic template simply rename the YOUR_TEMPLATE folder as per the install instructions below)

My answer remains the same. For anyone using the classic template they need to rename the YOUR_TEMPLATE folder to match their template folder name. This is not done any differently than a number of modules which use the exact same folder structure and do not include a module specific template folder for those using the classic template.

dbltoe:

Glenn,

The reason I added to this thread and opened another thread on defaulting stylesheets is that I had the same presumption as you until I tested this in 1.3.9e with classic.

Like you, I PRESUMED that the css would be picked up in the same manner as define_main_page.php or tpl_login_default.php.

However, unlike folders such as buttons, common, templates, etc., the css directory is NOT defaulted to any other directory than the current selected by the admin.

And a "cold load" of the add-on will load the "default-abled" filetypes to the template_default as you pointed out. So (again)... Brand spanking new 1.3.9c -- load IH2 -- run shop -- IH2 works incorrectly. It finds every file BUT the stylesheet.

After looking at the readme and doing some research, I offered the inclusion of the stylesheet to the classic template as a possible preventive measure to stop a few "it don't work" comments.

Your 8c has both custom_template and template_default as part of the package under templates.:dontgetit

I'm just gonna take my head and find a different wall.:P

:frusty:

Unicorn:

I can't get this to work.

First the medium watermark didn't show up. Then it did. So did the zoom. Now the watermark is gone again, although it's still there on medium images, but the zoom is gone from everywhere but the review images? And the large watermark never worked at all?

What's up with all this?

a link would be most beneficial to getting you better assistance

did you make certain to select in the settings to allow both the zoom and watermark in configuration

We did head off issues at the pass by covering things in the readme file.. The readme already has the following in it.. I think it's a little unnecessary to add it AGAIN to the "Other Troubleshooting Tips"

New Installation

2. Unzip the package to your local hard drive.

3. In the Store_Root folder, rename the admin folder to whatever you renamed your admin folder, if you still did not do that, just leave it like so. Rename the includes/templates/YOUR_TEMPLATE folder to your template name.

**Upgrade from Previous Versions of "Image Handler2 for v1.3.x"
(Rev 8b and prior versions)
**

2. BEFORE you install the Rev 8c files, you MUST uninstall the currently running version of Image Handler2 1.3.x. In Admin > Tools >Image Handler2 click on the "Admin" link, and click on "Remove Image Handler from database".

3. Delete the following from your current install:

• images/zoom.png

• images/medium/zoom_MED.png

• images/large/zoom_LRG.png

• includes/template/classic

(Please note: You only need to delete this folder if you are NOT using the Classic template. If you are using the Classic template you do not need to do this. Let me stress again DO NOT DELETE YOUR TEMPLATE FOLDER if you are using the Classic template!!!)

4. Replace the following files with the Zen Cart defaults:

• includes/modules/main_product_image.php

• includes/modules/additional_images.php

5. Unzip the package to your local hard drive.

6. In the Store_Root folder, rename the admin folder to whatever you renamed your admin folder, if you still did not do that, just leave it like so. Rename the includes/templates/YOUR_TEMPLATE folder to your template name.

dbltoe:

@Clyde,

Yes, that's why I am suggesting adding the stylesheet to the classic/css in the mod download.

**Possibly adding "Make sure style_imagehover.css is in your current template's css folder." to the "Other Troubleshooting Tips" will help **as I did not find it when I first noticed the "problem."

I realize you can't make something "idiot proof", but you can try to anticipate some of their mistakes and head them off at the pass.

dbltoe:

Your 8c has both custom_template and template_default as part of the package under templates.:dontgetit

I'm just gonna take my head and find a different wall.:P

:frusty:Not anymore.. that's what I have been trying to say.. Please re-download Rev8c again.. there are no template_default files in the package anymore... (it's likely they should have NEVER been included in any of the previous versions either..)

dbltoe:

Your 8c has both custom_template and template_default as part of the package under templates.:dontgetit

I'm just gonna take my head and find a different wall.:P

:frusty:

I can confirm this, since I just checked my download version of 8c.

clydejones:

I can confirm this, since I just checked my download version of 8c.
I concur.. However, since you both have downloaded the file this weekend, I did update it to remove both the classic and the default_template folders.. I have not yet updated the readme since I am waiting for some last bit of feedback from testers.. (kinda a formality at this point since it's been confirmed that the targeted fixes do in fact work..)

Sorry for the confusion..

ckosloff:

I have a reputation of arrogance and rudeness to maintain.

Keep it up - it's working for you.

DivaVocals:

Additionally I am of the opinion that "fixing" the IH2 code to allow for these symbols to be used in files names is an inherently BAD idea. Perhaps some of the developers who post here could weigh in on this thought.

Forgetting for a moment the particular issue of bracketing in filenames, it's clearly an inherently bad idea for users to incur errors of any sort that are preventable. Otherwise 99.5% of commercial software marketers would place less weight on user-friendliness than pleasing their purist IT teams. They don't.

You don't sell many vacuum cleaners if they malfunction when passing over plastic rugs because the manufacturer prefers shagpile.

ckosloff:

Diva Darling,
Goodness gracious!
Allowing for special characters that are used in our cherished Unix systems to be used in file names?
That would mean an aberrant mix between plebeian files and our noble kernel files, horrid spawns would ensue, often called "errors".
Arrogantly and pompously yours,
ckosloff

I realise you are not trying to sell this product - if you were you would spellcheck the docs for a start - but I'll wager that a lot of current and potential users will be happier when you see the sense in applying the same standards that commercial software sees fit to apply - even when it goes against the grain.

Perhaps this applies to Zencart in general if similar errors occur elsewhere. They are usually eradicated in the best commercial software for very good economic reasons and is an inherently good thing. I'm making a distinction here between "bugs" and deliberately accepting errors and displaying them.